Lemma Soft Forums

We've encountered another problem while coding Loren RPG. I noticed using windows resource monitor that every turn of the battle, the memory was increasing. For example at beginning of battle the process renpy.exe would occupy 170mb, and at the end of it would be 280mb!!
So I've asked Anima who is coding it (since I really don't understand much of python Classes and such) and he showed me this graph:

I copy paste his words because while I got the general meaning, I wouldn't know how to write in another way:


We tried using some tricks like setting:
config.hard_rollback_limit = 0
to disable it, but the object access graph was still the same even after we used that command.

So the question is: there's a way to solve this ? I believe is a Ren'Py bug? or we're doing something wrong? Thanks

edit: coder said it's not really a bug, but how the rollback works. Still there should be a way to "clear" the object that are in the rollback ?

_________________
follow me on
computer games

I think the problem is that if you do too much allocation in Python code without returning to Ren'Py code, Ren'Py will never tick the RollbackLog forward, and you can get this problem. Although I don't know your code, chances are that you have a Python while loop as your main loop. Replace that with a Ren'Py while loop as the main loop, and things should start working.

_________________
"It is not the critic who counts; not the man who points out how the strong man stumbles, or where the doer of deeds could have done them better. The credit belongs to the man who is actually in the arena, whose face in marred by dust and sweat and blood; who strives valiantly; who errs, who comes short again and again, because there is no effort without error and shortcoming" - Theodore Roosevelt

No we use a Ren'Py while loop. It looks like Jack got a better behavior with using a label/jump label construct instead of a while loop.
As an experiment I also tried a explicit counting loop to trick the rollback log, but it only accelerated the memory growth at an alarming rate.

It looks to me like a problem with loops and the rollback log in general, or that $ python lines are not counted.
I'll see if we get a somewhat stable memory situation with the label/jump combo.

Edit: The memory usage stabilizes pretty well and fast with the label/jump combination. There might be a problem with rollback log and while loops.

_________________
Avatar created with this deviation by Crysa
Currently working on:

• Winterwolves "Planet Stronghold 2" - RPG Framework: Phase II

Yes the good old label/jump label loop seems to have if not solved the issue completely, surely reduced the memory usage by a lot (I played a few test battles and I don't see the memory skyrocket anymore like before) Thanks

_________________
follow me on
computer games

Hm... can you put together a short demo of the problem? (Ideally, something where I can just click and see it.) The Ren'Py while loop really should advance the rollback log.

_________________
"It is not the critic who counts; not the man who points out how the strong man stumbles, or where the doer of deeds could have done them better. The credit belongs to the man who is actually in the arena, whose face in marred by dust and sweat and blood; who strives valiantly; who errs, who comes short again and again, because there is no effort without error and shortcoming" - Theodore Roosevelt

Ok will try to put a small demo together tomorrow (now is late and worked all day!)

_________________
follow me on
computer games

Please do so early. I want to get 6.13.10 out ASAP.

_________________
"It is not the critic who counts; not the man who points out how the strong man stumbles, or where the doer of deeds could have done them better. The credit belongs to the man who is actually in the arena, whose face in marred by dust and sweat and blood; who strives valiantly; who errs, who comes short again and again, because there is no effort without error and shortcoming" - Theodore Roosevelt

The main problem is to "reduce" the game code to a small demo - since it's part of a big set of classes written by Anima and I'm not 100% sure how to reduce it (I would just try to cut out all the stuff around the combat class but then it could crash)... maybe he can be quicker than me

_________________
follow me on
computer games

I made a small demo independent of Loren RPGs code. The effect is still present.
You'll need the objgraph module to run it.
Though the difference is pretty noticeable in general memory consumption even without it.

Edit: Improved version.

_________________
Avatar created with this deviation by Crysa
Currently working on:

• Winterwolves "Planet Stronghold 2" - RPG Framework: Phase II

Figured it out.

Basically, there was a rule in Ren'Py that said the rollback log must always contain a label. This was there for legacy reasons - on very old versions of Ren'Py, the statement identifiers for non-label statements weren't all that stable. Keeping a label around ensured that the game would always be loadable. In modern version of Ren'Py, statement identifiers are a lot more stable, so it isn't necessary to keep a label around anymore.

In the label-jump version of your code, Ren'Py would trim the rollback log - but in the while loop version, it never saw a label, and so Ren'Py let it grow. 6.13.10 will simply prune the log back to the rollback limit, removing the legacy behavior, and making both versions of the code identical.

Thanks for putting together that demo for me - a quick demo that lets me repeat the problem is the best way for me to address a hard-to-understand problem.

_________________
"It is not the critic who counts; not the man who points out how the strong man stumbles, or where the doer of deeds could have done them better. The credit belongs to the man who is actually in the arena, whose face in marred by dust and sweat and blood; who strives valiantly; who errs, who comes short again and again, because there is no effort without error and shortcoming" - Theodore Roosevelt

No, thank you for fixing it so fast. Besides, getting the while loop back is a good feeling.

_________________
Avatar created with this deviation by Crysa
Currently working on:

• Winterwolves "Planet Stronghold 2" - RPG Framework: Phase II

AH, that's the case in my game. I have the memory leak problem but didn't know how to solve it. thanks too.

_________________