[Solved]Did something change in translation.py? TypeError :(

[nintendotoad]

Code: Select all

$ nvlcap = NVLCharacter(None, kind=nvl, ctc=anim.Blink("extra/arrow.png"))

Code: Select all

    nvlmc "Oddly enough, the fact that I can't leave tells me that I am either in Heaven, Hell, or inside of my own head."
    nvls "How perceptive. I suppose that you know which of those three would be the most likely."
    nnvlmc "Clearly, I haven't died yet... actually, for the sake of argument, I should include that theory."
    $ answer_add(nvla(0, nvlq(None, "In front of me is an angel, this is Heaven.", "I wasn't good enough for Heaven; this is Hell.", 
        "Too good to be Hell and too bad to be Heaven; this is my head.", "There is no one else here; this is my head.")))
    nvlmc "I think I've figured it out. All right, new question..."
    

http://pastebin.com/raw.php?i=rzd2npqE
(This also happens on 6.17.7.521)

The basic idea is that I wanted a way to quickly write out and define questions being asked in NVL mode, and this worked for a time (even if the code itself is bad). After updating today however (it's been a while since I've updated my Ren'Py installation), the function no longer works as shown in the above traceback.

Help? (Oddly enough, nvlcap does get to say "his piece" before the crash; nvlmc however, never gets to say that he's figured it out.)

[PyTom]

Yes, I think this is my problem.

[PyTom]

Actually, it looked like my problem from the traceback. But trying it in 6.18, I can't repeat it. So please put together a replication under 6.18, so I can look at it.

[nintendotoad]

http://projectexist.net/repligame.zip

Replication under 6.18

[PyTom]

In retrospect, the problem is clear.

You define nvla as a function, and then redefine it to be a character. Since the functions and characters live in the same namespace, this replaces nvla. The second time it is called, it's a character, and you get a (admittedly, barely relevant) crash.

Nesting things three function calls deep isn't really good coding style, since it makes it hard to figure out which function call is causing an exception. (This is more just to give voice to a lesson I learned a long time ago, but which is something that is usually learned the hard way.) It was only when I un-nested the function that the problem became clear.

Anyway, I've gone ahead and made Character check early for this problem, so it doesn't bite people again. All's well that ends well.