suppress_overlay is True on return to game after Alt+F4

In this forum we discuss the future of Ren'Py, both bug fixes and longer-term development. Pre-releases are announced and discussed here.
Post Reply
Message
Author
iichan_lolbot
Veteran
Posts: 206
Joined: Tue Dec 30, 2008 9:18 am
Projects: iichan erogame
Contact:

suppress_overlay is True on return to game after Alt+F4

#1 Post by iichan_lolbot » Thu Sep 29, 2016 7:06 am

Hi,

Test case:
1. Run the game
2. Press "Start new game", see some dialogue
3. Notice "test" button in upper-left corner of the game in overlay
4. Press Alt+F4 or Close (x) button on the game window
5. Select "No" to return to game
6. Check if overlay still works

Expected result:
"test" button is still here

Actual result:
"test" button is gone

Workaround if prompts are never used in the game:
1. Edit renpy/common/00layout.rpy
2. Put "renpy.store.suppress_overlay = False" line before "return rv" in invoke_yesno_prompt() function
Attachments
overlay_bug.zip
minimal case demo
(3.68 KiB) Downloaded 18 times

User avatar
PyTom
Ren'Py Creator
Posts: 15893
Joined: Mon Feb 02, 2004 10:58 am
Completed: Moonlight Walks
Projects: Ren'Py
IRC Nick: renpytom
Github: renpytom
itch: renpytom
Location: Kings Park, NY
Contact:

Re: suppress_overlay is True on return to game after Alt+F4

#2 Post by PyTom » Thu Sep 29, 2016 11:56 pm

This was fixed in https://github.com/renpy/renpy/commit/4 ... 83964f2051 , which added context.pop_all_dynamic() to invoke_in_new_context.

Thanks for a great report.
Supporting creators since 2004
(When was the last time you backed up your game?)
"Do good work." - Virgil Ivan "Gus" Grissom
"Silly and fun things are important." - Elon Musk
Software > Drama • https://www.patreon.com/renpytom

iichan_lolbot
Veteran
Posts: 206
Joined: Tue Dec 30, 2008 9:18 am
Projects: iichan erogame
Contact:

Re: suppress_overlay is True on return to game after Alt+F4

#3 Post by iichan_lolbot » Fri Sep 30, 2016 7:08 pm

Thanks for the fix!

By the way, what are the plans for 6.99.12? Is it scheduled somewhere in Q42016?

User avatar
PyTom
Ren'Py Creator
Posts: 15893
Joined: Mon Feb 02, 2004 10:58 am
Completed: Moonlight Walks
Projects: Ren'Py
IRC Nick: renpytom
Github: renpytom
itch: renpytom
Location: Kings Park, NY
Contact:

Re: suppress_overlay is True on return to game after Alt+F4

#4 Post by PyTom » Fri Sep 30, 2016 11:41 pm

Yes. Since the goal is to improve support for Sierra, I'd like to get it out ASAP.
Supporting creators since 2004
(When was the last time you backed up your game?)
"Do good work." - Virgil Ivan "Gus" Grissom
"Silly and fun things are important." - Elon Musk
Software > Drama • https://www.patreon.com/renpytom

Post Reply

Who is online

Users browsing this forum: No registered users