Can someone find the error?

[briannavon]

I am having a problem with this code I'm using to teach someone. When I have this fight scene, it always choices the "get_hit" action and instead of either going back to the label or saying you won and going to another label, it ends the game. What is wrong?

Code: Select all

label fight_apple_monster_coven_forest :   
    show apple mad at center
    show screen mc_fight_screen
    show screen enemy_fight_screen
    call screen fight_main_choices
    if _return == "flee" :
        "You fled!"
        jump coven_forest
        
        
    if _return == "hit" :
        $ action = renpy.random.choice(['dodge', 'get_hit'])
        if action == "dodge" :
            if enemy_dodge >= dodge :
                show apple mad at right with move
                "It dodged your attack!"
                show apple mad at center with move
                $ action = renpy.random.choice(['dodge', 'get_hit'])
                if action == "dodge" :
                    if enemy_dodge <= dodge :
                      "You dodged it's attack!"
                      jump fight_apple_monster_coven_forest
                    
                    if enemy_dodge > dodge :
                       "It attacked you!"
                       $ hp -= enemy_attack
                       if hp <= 0 :
                          $ hp = 0
                          "You were defeated!"
                          scene black with dissolve
                          jump clinic_lost_fight
                        
                       if hp > 0 :
                          jump fight_apple_monster_coven_forest
                if action == "get_hit" :
                     $ action = renpy.random.choice(['normal', 'spin'])
                     if action == "normal" :
                         "It attacked you!"
                         $ hp -= enemy_attack 
                         if hp <= 0 :
                             $ hp = 0
                             "You were defeated!"
                             scene black with dissolve
                             jump clinic_lost_fight
                        
                         if hp > 0 :
                             jump fight_apple_monster_coven_forest 
                     if action == "spin" :
                         show apple spin at center
                         "It performed a spin attack!"
                         $ hp -= ("enemy_attack" + 3)
                         if hp <= 0 :
                             $ hp = 0
                             "You were defeated!"
                             scene black with dissolve
                             jump clinic_lost_fight
                        
                         if hp > 0 :
                             jump fight_apple_monster_coven_forest   
                         
                         
                    
            if enemy_dodge < dodge : 
                mon "Eeeeee!"
                "You attacked it!"
                $ enemy_hp -= attack
                if enemy_hp <= 0 :
                    hide apple mad with dissolve
                    "You defeated it!"
                    $ xp += 5
                    jump xp_gained
                    
                if enemy_hp > 0 :
                  $ action = renpy.random.choice(['dodge', 'get_hit'])
                  if action == "dodge" :
                    if enemy_dodge >= dodge :
                      show apple mad at right with move
                      "It dodged your attack!"
                      show apple mad at center with move
                      $ action = renpy.random.choice(['dodge', 'get_hit'])
                      if action == "dodge" :
                         if enemy_dodge <= dodge :
                            "You dodged it's attack!"
                            jump fight_apple_monster_coven_forest
                    
                         if enemy_dodge > dodge :
                             "It attacked you!"
                             $ hp -= enemy_attack
                             if hp <= 0 :
                                 $ hp = 0
                                 "You were defeated!"
                                 scene black with dissolve
                                 jump clinic_lost_fight
                        
                             if hp > 0 :
                                 jump fight_apple_monster_coven_forest
                      if action == "get_hit" :
                         $ action = renpy.random.choice(['normal', 'spin'])
                         if action == "normal" :
                            "It attacked you!"
                            $ hp -= enemy_attack 
                            if hp <= 0 :
                              $ hp = 0
                              "You were defeated!"
                              scene black with dissolve
                              jump clinic_lost_fight
                        
                            if hp > 0 :
                                jump fight_apple_monster_coven_forest 
                         if action == "spin" :
                                 show apple spin at center
                                 "It performed a spin attack!"
                                 $ hp -= ("enemy_attack" + 3)
                                 if hp <= 0 :
                                    $ hp = 0
                                    "You were defeated!"
                                    scene black with dissolve
                                    jump clinic_lost_fight
                        
                                 if hp > 0 :
                                         jump fight_apple_monster_coven_forest   
                            
                    
                    
                    
                
                
        if action == "get_hit" :    
                mon "Eeeeee!"
                "You attacked it!"
                $ enemy_hp -= attack
                if enemy_hp <= 0 :
                    hide apple mad with dissolve
                    "You defeated it!"
                    $ xp += 5
                    jump xp_gained
                    
                if enemy_hp > 0 :
                    
                  $ action = renpy.random.choice(['dodge', 'get_hit'])
                  if action == "dodge" :
                    if enemy_dodge >= dodge :
                      show apple mad at right with move
                      "It dodged your attack!"
                      show apple mad at center with move
                      $ action = renpy.random.choice(['dodge', 'get_hit'])
                      if action == "dodge" :
                         if enemy_dodge <= dodge :
                            "You dodged it's attack!"
                            jump fight_apple_monster_coven_forest
                    
                         if enemy_dodge > dodge :
                             "It attacked you!"
                             $ hp -= enemy_attack
                             if hp <= 0 :
                                $ hp = 0
                                "You were defeated!"
                                scene black with dissolve
                                jump clinic_lost_fight
                        
                             if hp > 0 :
                                 jump fight_apple_monster_coven_forest
                      if action == "get_hit" :
                         $ action = renpy.random.choice(['normal', 'spin'])
                         if action == "normal" :
                            "It attacked you!"
                            $ hp -= enemy_attack 
                            if hp <= 0 :
                              $ hp = 0
                              "You were defeated!"
                              scene black with dissolve
                              jump clinic_lost_fight
                        
                            if hp > 0 :
                                jump fight_apple_monster_coven_forest 
                         if action == "spin" :
                                 show apple spin at center
                                 "It performed a spin attack!"
                                 $ hp -= ("enemy_attack" + 3)
                                 if hp <= 0 :
                                    $ hp = 0
                                    "You were defeated!"
                                    scene black with dissolve
                                    jump clinic_lost_fight
                        
                                 if hp > 0 :
                                         jump fight_apple_monster_coven_forest   
                            
                    
                          
                       
                

[Ayutac]

First guess would be the screen fight_main_choices you didn't post. People a likely to see it to help you on this matter.

[briannavon]

Oh, I'm sorry! Here it is :

Code: Select all

screen fight_main_choices :
    frame xalign 0.0 yalign 0.8 :
        hbox :
            textbutton "Hit" action Return('hit')
            textbutton "Use Magic" action [ Hide('fight_main_choices') , Show('fight_magic_choices') ]
            textbutton "Use Items" action [ Hide('fight_main_choices') , Show('fight_item_choices') ]
            textbutton "Flee" action Return('flee')

[xela]

Consider teaching that someone some elif/else statements while at it Your code confused even yourself, how is your poor pupil supposed to feel

Absence of "get_hit" fork for "get_hit" branch and ("enemy_attack" + 3) also require your attention.

[briannavon]

Consider teaching them some elif/else statements while at it

Bad indentation on last "get_hit" and ("enemy_attack" + 3) also require your attention.

Oh sorry about that! Usually I know better but I was kinda rushing.

Anyway, I will see if changes those helps!

[xela]

Consider teaching them some elif/else statements while at it

Bad indentation on last "get_hit" and ("enemy_attack" + 3) also require your attention.

Oh sorry about that! Usually I know better but I was kinda rushing.

Anyway, I will see if changes those helps!

It wasn't bad ident, whole codeblock seems to be missing***

[briannavon]

Consider teaching them some elif/else statements while at it

Bad indentation on last "get_hit" and ("enemy_attack" + 3) also require your attention.

Oh sorry about that! Usually I know better but I was kinda rushing.

Anyway, I will see if changes those helps!

It wasn't bad ident, whole codeblock seems to be missing***

OK, then. Can you help me find where I forgot to put code at?

P.S. : Thank you for dealing with my stupidity

[xela]

Just switch to else and code should become more readable:

Code: Select all

        if action == "get_hit" :    
                mon "Eeeeee!"
                "You attacked it!"
                $ enemy_hp -= attack

                if enemy_hp <= 0 :
                    hide apple mad with dissolve
                    "You defeated it!"
                    $ xp += 5
                    jump xp_gained
                    
                else:
                  $ action = renpy.random.choice(['dodge', 'get_hit'])
                  if action == "dodge" : # Ident 18 
                    if enemy_dodge >= dodge :
                      show apple mad at right with move
                      "It dodged your attack!"
                      show apple mad at center with move
                      $ action = renpy.random.choice(['dodge', 'get_hit'])
                      if action == "dodge" : # Ident 22
                         if enemy_dodge <= dodge :
                            "You dodged it's attack!"
                            jump fight_apple_monster_coven_forest
                    
                         else:
                             "It attacked you!"
                             $ hp -= enemy_attack
                             if hp <= 0 :
                                $ hp = 0
                                "You were defeated!"
                                scene black with dissolve
                                jump clinic_lost_fight
                        
                             else:
                                 jump fight_apple_monster_coven_forest
                      else: # Ident 22
                         $ action = renpy.random.choice(['normal', 'spin'])
                         if action == "normal" :
                            "It attacked you!"
                            $ hp -= enemy_attack 
                            if hp <= 0 :
                              $ hp = 0
                              "You were defeated!"
                              scene black with dissolve
                              jump clinic_lost_fight
                        
                            else:
                                jump fight_apple_monster_coven_forest 
                         else:
                                 show apple spin at center
                                 "It performed a spin attack!"
                                 $ hp -= (enemy_attack + 3)
                                 if hp <= 0 :
                                    $ hp = 0
                                    "You were defeated!"
                                    scene black with dissolve
                                    jump clinic_lost_fight
                        
                                 else:
                                         jump fight_apple_monster_coven_forest
                                         
                 else:
                     # Add codeblock that covers "get_hit" at ident 18.