PW Shake effect not working

[thooruchan]

Hello, I have been having trouble with the Phoenix Wright shake effect.
When I first tried it on a test game, I copied the code as if, and it worked perfectly, However when I do it on my game, it always gives me the same error.

Code: Select all

I'm sorry, but an uncaught exception occurred.

While running game code:
  File "game/sidsimconvo.rpy", line 358, in script
    show sids at center, Shake(None, 0.5, dist=5)
  File "game/sidsimconvo.rpy", line 358, in <module>
    show sids at center, Shake(None, 0.5, dist=5)
NameError: name 'Shake' is not defined

I copied the shake code on it's own .rpy file, and it doesn't give me any trouble. It's when I try to define the effect, either on a new init: block ,or defining it, for example, along images, that it gives me an error.
The line i talk about is:

Code: Select all

init:
    $ sshake = Shake((0, 0, 0, 0), 1.0, dist=15)

I have no idea of what is wrong, because when I tried it before, it worked.
Sometimes i've found that some tutorials where it uses $, I have to change it for 'define', but in this case it didn't work
I use renpy 6.18.3 761

I would be really grateful for some help. It's a small detail that I would really like to be able to add to the game I'm making, if possible.

[MoonStar]

I use it also and it works for me.

shake.rpy (in my case)

Code: Select all

init:

    python:
    
        import math

        class Shaker(object):
        
            anchors = {
                'top' : 0.0,
                'center' : 0.5,
                'bottom' : 1.0,
                'left' : 0.0,
                'right' : 1.0,
                }
        
            def __init__(self, start, child, dist):
                if start is None:
                    start = child.get_placement()
                #
                self.start = [ self.anchors.get(i, i) for i in start ]  # central position
                self.dist = dist    # maximum distance, in pixels, from the starting point
                self.child = child
                
            def __call__(self, t, sizes):
                # Float to integer... turns floating point numbers to
                # integers.                
                def fti(x, r):
                    if x is None:
                        x = 0
                    if isinstance(x, float):
                        return int(x * r)
                    else:
                        return x

                xpos, ypos, xanchor, yanchor = [ fti(a, b) for a, b in zip(self.start, sizes) ]

                xpos = xpos - xanchor
                ypos = ypos - yanchor
                
                nx = xpos + (1.0-t) * self.dist * (renpy.random.random()*2-1)
                ny = ypos + (1.0-t) * self.dist * (renpy.random.random()*2-1)

                return (int(nx), int(ny), 0, 0)
        
        def _Shake(start, time, child=None, dist=100.0, **properties):

            move = Shaker(start, child, dist=dist)
        
            return renpy.display.layout.Motion(move,
                          time,
                          child,
                          add_sizes=True,
                          **properties)

        Shake = renpy.curry(_Shake)

then i use this in my script.rpy

Code: Select all

narator "{size= 50}Before I can think of an answer I feel 
as if the earth is shaking more and more intensely...... {w=5}Several seconds later it stops.{/size}" with Shake((0, 0, 0, 0), 5.0, dist=30)

and works every time you dont need to do any init in script.rpy only call it with "with Shake" and give him the right parameters.

[thooruchan]

I get the same, it keeps telling me Shake is not defined.
I just don't know what the problem is anymore

[MoonStar]

I get the same, it keeps telling me Shake is not defined.
I just don't know what the problem is anymore

did you put shake.rpy code in a separate rpy file? and then just ran/called the shake command with "with shake..." at the end of the line where you want to cause the shake?

it may be helpful if you post or attach the files to view them and see whats the problem.

[thooruchan]

I get the same, it keeps telling me Shake is not defined.
I just don't know what the problem is anymore

did you put shake.rpy code in a separate rpy file? and then just ran/called the shake command with "with shake..." at the end of the line where you want to cause the shake?

it may be helpful if you post or attach the files to view them and see whats the problem.

I did all of that. I also put the line

Code: Select all

init:
    $ sshake = Shake((0, 0, 0, 0), 1.0, dist=15)

and that's when I start getting the error. no matter if I use "at Shake" or "with Shake", I always get the same message.

[MoonStar]

I get the same, it keeps telling me Shake is not defined.
I just don't know what the problem is anymore

did you put shake.rpy code in a separate rpy file? and then just ran/called the shake command with "with shake..." at the end of the line where you want to cause the shake?

it may be helpful if you post or attach the files to view them and see whats the problem.

I did all of that. I also put the line

Code: Select all

init:
    $ sshake = Shake((0, 0, 0, 0), 1.0, dist=15)

and that's when I start getting the error. no matter if I use "at Shake" or "with Shake", I always get the same message.

attach your script or paste the code here pls

[thooruchan]

OK after looking at your script and the tutorial and revising everything I managed to make it work.
thanks for helping me figure it out! T___T