Sprite Position Bug -- Are other creators seeing this?

[xela]

floor_left_crouching == ??? Sack of potatoes? Pie? A cat?

with moveinbottom

is a Transition, you are not even supposed to get the issue we're discussing here when using it. My guess is that you screwed up when defining whatever "floor_left_crouching" was supposed to be (it's still a guess).

[Rosstin]

Code: Select all

    $ floor_left_crouching = Position(xpos=left_x, ypos=floor_height_crouching, xanchor='center')    

Code: Select all

    $left_x = 300

Code: Select all

    $ floor_height_crouching = 1900 #height of floor in pixels below top of screen, for a crouching character

[nyaatrap]

at Position(pos) with Transition is an old way before ATL is introduced. If you want to animate sprits, I'd suggest to do like the following,

Code: Select all

show sprite:
    align (.5, 1.0) #the final position
    xoffset -100 # the starting position
    linear 1.0 xoffset 0 # from left to right move animation
say "text"
show sprite:
    xoffset 0 # reset animation for the case when ATL is terminated.
say "next text"

[Rosstin]

So basically you're telling me that... in our script, thousands of instances of 1 line of code should be replaced with 6 lines of code?

Our script is 20,000 lines long and we have thousands of these statements.

[nyaatrap]

You can define them in ATL (or in pure python) http://www.renpy.org/doc/html/atl.html

[Rosstin]

So you're saying that this form....

Code: Select all

show someCharacter at somePosition with someTransition

is no longer supported by Renpy?

And now I should use....

Code: Select all

show someCharacter:
    onScreenPosition
    offScreenPosition
    slowEase

for example?

[nyaatrap]

It may work, but obsoleted. You may hard to get help on functions few developers are using. I have no idea how to fix the matter in that form.

You can also write them in at clause after dfine them as variables in ATL

Code: Select all

show sprite:
    defined_position
    defined_animation
show sprite at defined_position, defined_animation

[Rosstin]

So are...

Positions
&
Transitions

also deprecated?

All I want is to write a single-line statement that says....
"someCharacter moves from thisPosition to thatPosition with someTransition"
I'd really like not to have to change all those statements into massive multiline statements.

[philat]

I actually can't even replicate this problem.

Code: Select all

image red = Solid("F00", xysize=(600, 400))

label start:
    $ left_x = 300
    $ floor_height_crouching = 100 #height of floor in pixels below top of screen, for a crouching character
    $ floor_left_crouching = Position(xpos=left_x, ypos=floor_height_crouching, xanchor='center')    
    "blah"
    show red at floor_left_crouching with moveinbottom
    "blah blah"

In a clean project does not result in any issues -- if you click through the transition, the image jumps to the end state (xpos 300, ypos 100).

[Rosstin]

I zipped up a project that demonstrates the problem for PyTom, I will post it for you guys as well.

https://drive.google.com/open?id=0B-KLE ... GpGd2tfMGM

Just, you know, don't delete it from my Google Drive or anything because I want Tom to see it.

To replicate the bug, just view the short game once, then try to skip through it the second time with CTRL. You should see something weird. Then you can also try using the mousewheel scroll backwards to also trigger it.

The relevant code is all in script.rpy.

I apologize for the file size (100mb), it would take me over an hour to carefully extract all the code referencing the game images.

[xela]

it would take me over an hour to carefully extract all the code referencing the game images.

Hour is too long (you should need that much to point out the issue) but it's fair, 100MB is not much these days...

I zipped up a project that demonstrates the problem for PyTom

I honestly do not believe that it should become PyTom's problem, you are using outdated tools which are no longer supported.

To replicate the bug, just view the short game once, then try to skip through it the second time with CTRL. You should see something weird. Then you can also try using the mousewheel scroll backwards to also trigger it.

Actually, you can just click lmb right after the game starts and you see the "issue".

The relevant code is all in script.rpy.

My strategy would be to try and preserve written code by redefining all Position classes as Transforms, that is at least worth trying before rewriting the whole script.

[xela]

My strategy would be to try and preserve written code by redefining all Position classes as Transforms, that is at least worth trying before rewriting the whole script.

Yeah, seems to be working well! Try this:

Use mass-renaming option (your code editor should have one) to replace (if fx file) all:

Position

with

Transform

and all:

xanchor='center'

with

anchor=(0.5, 1.0)

It should work great then and you will have to change another line anywhere in the code (replacing took me 4 secs once I knew what to replace).

===>>
Could you add:

Code: Select all

image mmvertpan:
    "gui/newUI/mmvertpan.png"
    subpixel True
    xanchor 0.0
    yanchor 0.0
    xalign 0.0
    yalign 1.0
    ease 20.0 yalign 0.0

It's none of my business and unrelated to the the issue at hand but it'll help lessen (or remove completely) small (but really annoying) skips when the background is "panning".

==========>>>
I hope this will fix the issue for good, seems to have done the trick for me at least (and try to avoid using outdated code in the future)...

[Rosstin]

Thank you so much! I'll try this out.

Alright, let's do this. Crossing my fingers.

[Rosstin]

OMG I THINK THAT DID IT

YOU SAVED MY LIFE T_T

It looks like this has f---ed up a handful of things in the screen animation but probably things we can fix on an ad-hoc basis.

[Rosstin]

OK, so these new positions work great with our Full Sprites (all the main characters)

Our custom positions no longer work with our Half Sprites (the NPC characters)

That's a way smaller problem than we had before. I just have to review all these scenes in which we manipulate the Half Sprites and redo them. Most of our scenes feature the Full Sprites so this isn't THAT much work.