Initialising a list of a class within a class

[Iylae]

Hi all,

As much as I'd love for my first post to not be a question, here it is:

I'm struggling with properly initialising lists and classes to build a data structure.

Trait is a custom class containing a name (for now)
Char is a custom class which should have a list of Trait (and other vars)

The only line in the start label is to find the name of the first trait on the Char prax.

I've been going around in circles for the past few hours, but cannot find anything to explain where I'm going wrong with this. Thanks for any help!

Code: Select all

I'm sorry, but an uncaught exception occurred.

While running game code:
  File "game/script.rpy", line 22, in script
    "[prax.traits[0].name]"
AttributeError: Trait instance has no attribute 'name'

-- Full Traceback ------------------------------------------------------------

Full traceback:
  File "game/script.rpy", line 22, in script
    "[prax.traits[0].name]"
  File "E:\renpy-6.99.8-sdk\renpy\ast.py", line 603, in execute
    renpy.exports.say(who, what, interact=self.interact)
  File "E:\renpy-6.99.8-sdk\renpy\exports.py", line 1121, in say
    who(what, interact=interact)
  File "E:\renpy-6.99.8-sdk\renpy\character.py", line 819, in __call__
    what = what_pattern.replace("[what]", sub(what, translate=translate))
  File "E:\renpy-6.99.8-sdk\renpy\character.py", line 801, in sub
    return renpy.substitutions.substitute(s, scope=scope, force=force, translate=translate)[0]
  File "E:\renpy-6.99.8-sdk\renpy\substitutions.py", line 229, in substitute
    s = formatter.vformat(s, (), kwargs)
  File "/home/tom/ab/x64lucid-deps/install/lib/python2.7/string.py", line 563, in vformat
  File "/home/tom/ab/x64lucid-deps/install/lib/python2.7/string.py", line 585, in _vformat
  File "/home/tom/ab/x64lucid-deps/install/lib/python2.7/string.py", line 652, in get_field
AttributeError: Trait instance has no attribute 'name'

Windows-8-6.2.9200
Ren'Py 6.99.8.959
test 0.0

Code: Select all

init python:
    
    class Trait:
        def __init__(self, name="Genius"):
            self.name = name
            
    class Char:
        def __init__(self,  name="unknown", age="unknown", traits="unknown"):
            self.name = name
            self.age = age
            self.traits = traits
            
init:
    $ prax = Char(
        name = "Prax", 
        age = 35,
        traits = [Trait()],
        )
    
label start:
    
    "[prax.traits[0].name]"

[Evildumdum]

I can see a couple of potential problems. Though i'm only certain on how to fix one or two. Others will have to clarify the others. The first is in your label start.

Code: Select all

 "[prax.traits[0].name]"

Why are you trying to call two variables in the same string? Separate them.

Code: Select all

"[prax.traits[0]] [prax.name]"

Secondly i'm not sure you are inputting your lists in the right format when creating your class instance. However having never tried doing it that way i cant give proper advice on that. You might want to look further into that though.

Third, your class instance doesn't need to be that complicated. Just do.

Code: Select all

init:
    $ prax = Char("Prax", 35, [Trait()])

Lastly, if you are going to have other classes inherit from an existing class, you need to make it an object. Easy enough to do.

Code: Select all

class Trait(object):
        def __init__(self, name="Genius"):
            self.type = type

[Iylae]

I made a bit of a mistake in my code which I've edited now:

Code: Select all

    class Trait:
        def __init__(self, name="Genius"):
            self.name = name

Why are you trying to call two variables in the same string? Separate them.

I want the name of the trait, not the name of the char.

Lastly, if you are going to have other classes inherit from an existing class, you need to make it an object. Easy enough to do.

Code: Select all

class Trait(object):
        def __init__(self, name="Genius"):
            self.type = type

That was the issue, it works fine when adding the object parameter to the class definition.

So the functional code is:

Code: Select all

init python:
    
    class Trait(object):
        def __init__(self, name="Genius"):
            self.name = name
            
    class Char:
        def __init__(self,  name="unknown", age="unknown", traits="unknown"):
            self.name = name
            self.age = age
            self.traits = traits
            
init:
    $ prax = Char(
        name = "Prax", 
        age = 35,
        traits = [Trait()],
        )
    
label start:
    
    "[prax.traits[0].name]" # prints "Genius"

Though that's not to say I'm doing this in the "best" way.

[Evildumdum]

Here, this will help.

https://www.youtube.com/watch?v=trOZBgZ8F_c
https://www.youtube.com/watch?v=pxbdnrj ... KWAJibUGi6
https://www.youtube.com/watch?v=TF_y8Gt ... i6&index=2
https://www.youtube.com/watch?v=rOaRMW8 ... KWAJibUGi6