Ren'Py 6.99.9 Prereleased

[PyTom]

Correct. Audio and sound share the sfx mixer, so use config.default_sfx_volume to set it.

[nyaatrap]

Though it looks config.default_sfx_volume does nothing on menu/click sounds.

[vollschauer]

Well config.default_sfx_volume works for me ....
I use this one in my options.rpy to set my default volumes

Code: Select all

    ## The default audio volumes
    config.default_music_volume = 0.5
    config.default_sfx_volume = 0.7
    config.default_voice_volume = 1.0

[akakyouryuu]

Doesn't renpy.music.get_duration work for audio including the specification of start, end, and loop points?

[nyaatrap]

In the tutotial game config.default_sfx_volume is working. I guess the following code in my game prevents it's working?

Code: Select all

renpy.music.register_channel("audio", mixer="audio", loop=False, file_prefix="sound/", file_suffix=".mp3")

[edit] Yes. This was the culprit. When I use this code, config.auto_channels is nullified.

[PyTom]

Doesn't renpy.music.get_duration work for audio including the specification of start, end, and loop points?

Yes, but it returns the total length of the underlying file. (Assuming that length is known - which isn't the case for all possible files.)

[xela]

If possible (I really hope that it is somehow), we need an option to play the movie sprite just once (or set the amount of loops for it), it's very hard to time hiding them perfectly if animation is required to play itself just once, especially in messier cases with loads of going on on the screen, every now and then an extra frame from the next loop just manages to sneak in somehow

From the dev docs:

buffer_queue
Should we buffer the first second or so of a queued file? This should be True for audio, and False for movie playback.

Is it False for movie playback by default? I get issues after a few Movie sprite loops with a mask on with the buffer_queue set to False while True always seem to be working perfectly.

[PyTom]

Now that we can queue movies up, buffer_queue should always be set to True.

You should be able to play a movie once-through using something like:

Code: Select all

image mymovie = Movie(channel="mymovie")

label start:
    show mymovie
    play mymovie noloop
    pause 42.0
    hide mymovie

[xela]

Code: Select all

image mymovie = Movie(channel="mymovie")

label start:
    show mymovie
    play mymovie noloop
    pause 42.0
    hide mymovie

It claims that noloop is not defined. Is there a python equivalent, last Ren'Py statement in the project where I am testing this is a couple hundred python statements behind.

Or is the the same as renpy.music.play(loop=False)?


== deleted ==


You've pointed me to the right method (I couldn't figure out what's what in this new displayable, I think I understand it a bit better now):

Code: Select all

        if self._play != old_play:
            if self._play:
                renpy.audio.music.play(self._play, channel=self.channel, loop=True, synchro_start=True)

                if self.mask:
                    renpy.audio.music.play(self.mask, channel=self.mask_channel, loop=True, synchro_start=True)

It's just a matter of expanding the class a little bit.

Thanks for the new functionality, using webm instead of FilmStrips or Animation is absolutely amazing, quality and size improvements are trully astounding. I'll second the:

movie sprites = the future.

statement

[kevinturner]

Turns out the curse of the dashes is not quite over. After removing all of the dashes from the game, everything worked fine in Ren'Py 6.99.9.1156. However, attempting to launch the same project in 6.99.9.1168 causes the following error:

Code: Select all

I'm sorry, but an uncaught exception occurred.

While running game code:
  File "renpy/common/00images.rpy", line 26, in script
    init 1900 python hide:
  File "renpy/common/00images.rpy", line 54, in <module>
    scan_images_directory()
  File "renpy/common/00images.rpy", line 52, in scan_images_directory
    renpy.image(base, fn)
Exception: Image name components may not begin with a -.

-- Full Traceback ------------------------------------------------------------

Full traceback:
  File "renpy/common/00images.rpy", line 26, in script
    init 1900 python hide:
  File "/Applications/renpy-6.99.9-sdk 6.55.30 PM/renpy/ast.py", line 806, in execute
    renpy.python.py_exec_bytecode(self.code.bytecode, self.hide, store=self.store)
  File "/Applications/renpy-6.99.9-sdk 6.55.30 PM/renpy/python.py", line 1461, in py_exec_bytecode
    exec bytecode in globals, locals
  File "renpy/common/00images.rpy", line 54, in <module>
    scan_images_directory()
  File "renpy/common/00images.rpy", line 52, in scan_images_directory
    renpy.image(base, fn)
  File "/Applications/renpy-6.99.9-sdk 6.55.30 PM/renpy/exports.py", line 341, in image
    renpy.display.image.register_image(name, d)
  File "/Applications/renpy-6.99.9-sdk 6.55.30 PM/renpy/display/image.py", line 86, in register_image
    raise Exception("Image name components may not begin with a -.")
Exception: Image name components may not begin with a -.

Darwin-15.3.0-x86_64-i386-64bit
Ren'Py 6.99.9.1168
Highway Blossoms 0.0

As far as I can tell, there are no images with dashes in them any more (or it would have broken the previous 6.99.9 build). No errors are generated, only the traceback is generated.

Commenting out lines 84-86 in image.py:

Code: Select all

    #for i in name:
    #    if i and i[0] == '-':
    #        raise Exception("Image name components may not begin with a -.")

fixes the issue/sweeps the problem under the rug as far as I can tell.

[PyTom]

kevinturner

Can you uncomment that code, and change line 86 to:

Code: Select all

            raise Exception("Image name components may not begin with a -. (in %r)" % name)

The code seems fairly straightforward to me. Also, it's doing this in the images directory, so look in there for a file beginning with - , or that has <space>- in it.

[PyTom]

Sorry, make that line:

Code: Select all

                raise Exception("Image name components may not begin with a - (in {!r}).".format(name))

[kevinturner]

That returns

Code: Select all

I'm sorry, but an uncaught exception occurred.

While running game code:
  File "renpy/common/00images.rpy", line 26, in script
    init 1900 python hide:
  File "renpy/common/00images.rpy", line 54, in <module>
    scan_images_directory()
  File "renpy/common/00images.rpy", line 52, in scan_images_directory
    renpy.image(base, fn)
Exception: Image name components may not begin with a - (in (u'20', u'-', u'las', u'vegas', u'strip', u'night')).

-- Full Traceback ------------------------------------------------------------

Full traceback:
  File "renpy/common/00images.rpy", line 26, in script
    init 1900 python hide:
  File "/Applications/renpy-6.99.9-sdk 6.55.30 PM/renpy/ast.py", line 806, in execute
    renpy.python.py_exec_bytecode(self.code.bytecode, self.hide, store=self.store)
  File "/Applications/renpy-6.99.9-sdk 6.55.30 PM/renpy/python.py", line 1461, in py_exec_bytecode
    exec bytecode in globals, locals
  File "renpy/common/00images.rpy", line 54, in <module>
    scan_images_directory()
  File "renpy/common/00images.rpy", line 52, in scan_images_directory
    renpy.image(base, fn)
  File "/Applications/renpy-6.99.9-sdk 6.55.30 PM/renpy/exports.py", line 341, in image
    renpy.display.image.register_image(name, d)
  File "/Applications/renpy-6.99.9-sdk 6.55.30 PM/renpy/display/image.py", line 86, in register_image
    raise Exception("Image name components may not begin with a - (in {!r}).".format(name))
Exception: Image name components may not begin with a - (in (u'20', u'-', u'las', u'vegas', u'strip', u'night')).

Darwin-15.3.0-x86_64-i386-64bit
Ren'Py 6.99.9.1168
Highway Blossoms 0.0

which is almost certainly referring to:

Code: Select all

image bg VegasStripNight = "images/bg/20 - Las Vegas Strip Night.jpg"

I guess it's also checking filenames for this pattern and/or trying to auto-declare images and treating that separated dash in the file name as a tag that is only a dash.

Edit: Getting rid of the dashes from the filename fixes the issue.

[PyTom]

Actually, never mind. You can do the above if you're interested, but I've moved the appropriate checks into the parsing of the image statment, as of the next nightly build. Until then, just leave the check commented out.

EDIT: Crossed in posting.

[kevinturner]

It's OK, I haven't actually used that image yet outside of that image statement so it was a super easy fix. Plus, I need those filenames clean so I can break the next nightly with even more obscure placement of dashes