Would it be the best idea to update code?

[namastaii]

What I mean by this is if I'm currently using a structure like this:

Code: Select all

style.my_button.background

would it make much of a difference to update it to this:

Code: Select all

style my_button:
    background:

One is using Python while the other is using Ren'Py's language, right? Does it really not matter or is one truly better than the other?

[Donmai]

Although the old syntax is still valid, the changes were made not only to make the code simpler to create and edit, but also to increase its performance.

The new code reduces the amount of time it takes to create a new style to a small fraction of the previous time. Since every displayable creates an associated style, this has the potential to lead to a substantial performance improvement.

Lengthy and redundant code like:

Code: Select all

init python:
    style.quick_button_text.set_parent('default')
    style.quick_button_text.size = 12
    style.quick_button_text.idle_color = "#8888"
    style.quick_button_text.hover_color = "#ccc"

can be replaced with:

Code: Select all

style quick_button_text is default:
    size 12
    idle_color "#8888"
    hover_color "#ccc"

https://www.renpy.org/doc/html/changelo ... en-py-6-17

[namastaii]

Does it affect performance?

[theCodeCat]

I don't know the details but I pretty sure any performance increase or decrease is negligible. Just use whatever style works for you.

[Donmai]

I don't know the details but I pretty sure any performance increase or decrease is negligible.

Well, I also don't know he details, but the documentation isn't calling it "negligible".

The new code reduces the amount of time it takes to create a new style to a small fraction of the previous time. Since every displayable creates an associated style, this has the potential to lead to a substantial performance improvement.

But yes, if the old way works and you prefer it, go for it. The Amish prefer to live in houses with no electricity, and their houses still work.

[theCodeCat]

The reason I think it's likely negligible is because creating a new style is likely a one-time occurrence that happens during the game's initialization, and it probably takes less than 1/100th of a second even when done inefficiently.
Given those time estimates, even if this new style made the creation process instantaneous, you are saving less than 1/100th of a second when the game initially boots up. With performance differences that small I think you are better off ignoring them completely.

[namastaii]

Less typing is definitely better. Instead of typing out each line starting with style. May be easier to sort through too