[Solved]Custom Profanity filter keeps resetting at main menu

[Imperf3kt]

Hi, in my game I decided to add a filter for users to decide if they wanted swearing in the game or not. My original script has mild coarse language and I figured some users would prefer to have no course language.

So in my preferences screen I added the option with the following code:

Code: Select all

vbox:
                    style_prefix "radio"
                    label _("Profanity")
                    textbutton _("Block") action SetVariable ("profanity", 0)
                    textbutton _("Allow") action SetVariable ("profanity", 1)

And then I made some additions within an init-2 block just before label start:, that check the variable.

Code: Select all

init -2:
    if profanity == 0:
        $ shit = _("Crap")
    elif profanity == 1:
        $ shit = _("Shit")

label start:

And in the script, it is invoked by something like:

Code: Select all

    mcs "[shit!t], already?"

But, after thinking about this, the way I was doing it was less than ideal. I'd have a long list of words by the time I was done, and making sure I had everything right would be a headache.


I modified my code to the following:

Code: Select all

init -2:
    default profanity = 0

label start:

And invoke it with:

Code: Select all

    if profanity == 0:
        mcs "Crap, already?"
    elif profanity == 1:
        mcs "Shit, already?"

More typing, I know, but it is a lot easier to work with and less room for error.

My problem is, that whenever I click "allow" in the preferences menu, it only stays "allowed", whilst browsing the menu's and playing the game. If a user returns to the main menu, or reaches the end of the script, thus also returning to the main menu, profanity = 1 reverts to profanity = 0 every time.

Am I doing it wrong, because I feel the option should stay the same, like the other options in preferences menu do.

Preferences when the game first starts (and every time you load it again)

Default

Preferences whilst in-game, having selected to allow profanity

profanity = 1

But as soon as you reach the end of the script or return to the main menu, it returns to it's default state.
Loading a game, previously saved with profanity allowed, stays allowed.

Edit: Game code removed as it was a massive WOT (Wall Of Text) and the issue has been resolved, so it is now unnecessary.

[Divona]

My problem is, that whenever I click "allow" in the preferences menu, it only stays "allowed", whilst browsing the menu's and playing the game. If a user returns to the main menu, or reaches the end of the script, thus also returning to the main menu, profanity = 1 reverts to profanity = 0 every time.

Am I doing it wrong, because I feel the option should stay the same, like the other options in preferences menu do.

Use persistent:

Code: Select all

define persistent.profanity = 0

label start:
    . . .

    if persistent.profanity == 0:
        mcs "Crap, already?"
    elif persistent.profanity == 1:
        mcs "Shit, already?"

In "screens.rpy":

Code: Select all

vbox:
    style_prefix "radio"
    label _("Profanity")
    textbutton _("Block") action SetField(persistent, "profanity", 0)
    textbutton _("Allow") action SetField(persistent, "profanity", 1)

[Imperf3kt]

I tried persistent.profanity but it only threw errors within SetVariable. Somehow this didn't get posted with the rest of my message.

Your explanation seems to have done the trick though, thank you very much.
My issue was in screens.rpy, I tried:

Code: Select all

textbutton _("Block") action SetField(persistent.profanity, 0)
textbutton _("Allow") action SetField(persistent.profanity, 1)

When I should have used:

Code: Select all

textbutton _("Block") action SetField(persistent, "profanity", 0)
textbutton _("Allow") action SetField(persistent, "profanity", 1)

Thank you again for the help, it works like a charm.

[Imperf3kt]

Hello again. Small problem,
If a player does not go to the options menu and select their preference, the lines are skipped altogether and neither variant is shown.

[Divona]

Hello again. Small problem,
If a player does not go to the options menu and select their preference, the lines are skipped altogether and neither variant is shown.

Did you define the persistent variable?

Code: Select all

define persistent.profanity = 0

label start:
    . . .

Load from previous save could have problems because the variable wasn't there in the save.

[Imperf3kt]

That did the trick. I did write it in, but I did further editing afterwards, and it seems that somewhere in my edit / undo / redo, I undid it.

Thanks, all good now.