Menu choices that change depending on a setting? SOLVED

[Aviala]

Hey all!

I want to include an option in my game that lets the player choose whether menu choices show which resources it affects.
Like if there is a choice "Give alms to the poor" it would also show an image of a coin to indicate that your Wealth resource is affected. But I want an option to turn the coin icon on/off since different players prefer different things - some want to be surprised, and some want to balance their resources as efficiently as possible.

How would I do that? Is it possible to include if statements inside a menu option? Something like this?
menu:
"Give alms to the poor" if option == True: {image=coin.png}

I assume this doesn't work as-is, could someone help me out?

[Imperf3kt]

If I'm understanding this correctly, you want to set an inline image in a choice menu by conditionals?

Sure that should work.
Just rearrange your if statement:

Code: Select all

label mygame:

    menu:
        if option == True:
            "Give alms to the poor {image=coin.png}":
                call my_function
        else:
            "Give alms to the poor":
                call my_function

[trooper6]

You can also alter the choice screen code itself. I'd model it off of code discussed in this and related threads: viewtopic.php?f=8&t=25453&p=313338

[TheChatotMaestro]

If you wanted something less complex then making the choices appear and disappear, just have multiple menus.

Code: Select all

"Hi this is the text before the menu."
if $ variable 1 == on
	jump menu1
else 
	jump menu2
	
label menu1
	"Yes"
		menu stuff
	"No"
		menu stuff
label menu2
	"Yes with image!"
		menu stuff
	"No"
		menu stuff

Less refined but kinda easier to understand? You wouldn't have to worry about the image accidentally being on when its supposed to be off or vice versa if it cant ever be on in one and ever be off in the other.

[Imperf3kt]

If you wanted something less complex then making the choices appear and disappear, just have multiple menus.

Code: Select all

"Hi this is the text before the menu."
if $ variable 1 == on
	jump menu1
else 
	jump menu2
	
label menu1
	"Yes"
		menu stuff
	"No"
		menu stuff
label menu2
	"Yes with image!"
		menu stuff
	"No"
		menu stuff

Less refined but kinda easier to understand? You wouldn't have to worry about the image accidentally being on when its supposed to be off or vice versa if it cant ever be on in one and ever be off in the other.

This does exactly the opposite of what is advertised. This is just a more complex way of doing the same thing shown in my reply.

IMO, you've made it unnecessarily complicated.

[philat]

Code: Select all

label mygame:

    menu:
        if option == True:
            "Give alms to the poor {image=coin.png}":
                call my_function
        else:
            "Give alms to the poor":
                call my_function
                

This doesn't work, because menu doesn't process ifs -- if you run this, this simply throws an error (expected menuitem).

Code: Select all

menu:
    "Give alms to the poor {image=coin.png}" if option:
        "blahblah with image"
    Give alms to the poor" if not option:
        "blahblah without image"

is the simple way to do it.

The thread (and related threads) trooper references would require some up-front set up but would be easier to use down the line.

Code: Select all

menu:
    "Give alms to the poor (coin)":
        "blahblah"
    
screen choice:
    # conceptually, if option, replace (coin) with {image=coin.png} or separately add "coin.png", whatever floats your boat
    # else replace (coin) with blank space
 

[Imperf3kt]

It does?
Could have sworn I'd used such a thing before, but checking what scripts I still have on me confirms that I am very likely wrong.

So please disregard my prior answer. It is incorrect and misleading.

[Remix]

Another alternative is to declare your own custom text tag and run a function to return the correct string/icon/whatever

Semi simplified code:

Code: Select all

init python:
    menu_icon_names = ['coin', 'food', 'water']
    # this just builds a dictionary for the above keys with True pointing at an icon
    menu_icons_map = {k: {True:'images/icons/{0}.png'.format(k), False:''} for k in menu_icon_names}
    show_icons = True

    # basically interprets the {menu_icon=???} text tag and slips in an image if needed
    def get_menu_icon(tag, argument, contents):
        type, icon_str = renpy.TEXT_TEXT, ''
        if show_icons:
            icon_str = 'No icon defined for {0}'.format( argument )
            if menu_icons_map.has_key( argument ) and menu_icons_map[ argument ].has_key( show_icons ):
                d = renpy.easy.displayable( menu_icons_map[ argument ][ show_icons ] )
                type, icon_str = renpy.TEXT_DISPLAYABLE, d
        return [ ( type, icon_str ) ]

    config.custom_text_tags["menu_icon"] = get_menu_icon

label start:
    # debug line to check dictionary
    $ k = str(menu_icons_map).replace('{', '{{').replace('[','[[')
    "Icons Dict [k]"
    menu:
        "Icon: {menu_icon=coin}{/menu_icon}":
            jump coin_label
        "Choice with icon {menu_icon=food}{/menu_icon}":
            jump food_label
    "Second Line"
    "Last Line"
    return

A little code tidying wouldn't go amiss there... I based it on some other code which had more dictionary keys. You wouldn't really need False as the function checks the show_icons variable anyway...

[Aviala]

Thanks guys, I'm not a very experienced coder but I think I'll try fiddling with the choice screen code. We have a lot of choices and it seems like this would make them a lot faster to code.

Remix, your suggestion is a bit hard for me to understand since I don't know a lot of Python, so I think I'll try the other suggestions first. But it's good to have multiple solutions in case I can't make some of them work. :)

[Aviala]

Hey all, just wanted to give a little update. I managed to somehow make it work. As I mentioned before, I'm still a beginner at coding, so the following code probably could be prettier. But it works!

Basically, now when I write (wealth) at the end of the choice text, it displays an image of a coin, and if the option is turned off, it doesn't display the coin image - exactly what I wanted!

Code: Select all

screen choice(items):
    style_prefix "choice"

    vbox:
        for i in items:
            
            if i.action:
                
                textbutton i.caption action i.action
                
                if "(wealth)" in i.caption:
                    
                    if icons == True:
                        $ i.caption = i.caption.replace("(wealth)", "{image=images/coin.png}")
                    else:
                        $ i.caption = i.caption.replace("(wealth)", " ")
                    
                    
                if "(happiness)" in i.caption:
                    if icons == True:
                        $ i.caption = i.caption.replace("(happiness)", "{image=images/smiley.png}")
                    else:
                        $ i.caption = i.caption.replace("(happiness)", " ")
                
                if "(loyalty)" in i.caption:
                    if icons == True:
                        $ caption = caption.replace("(loyalty)", "{image=images/crown.png}")
                    else:
                        $ caption = caption.replace("(loyalty)", " ")
                    
                if "(army)" in i.caption:
                    if icons == True:
                        $ caption = caption.replace("(army)", "{image=images/sword.png}")
                    else:
                        $ caption = caption.replace("(army)", " ")
                
                        
                        
                else:
                    pass
                   
                    
            else:
                pass