[Solved] Problem modifying notify() to accept two arguments

[Errilhl]

I'm trying to modify the notify-screen, to accept two variables (so I can change how the notification looks on-the-fly):

Code: Select all

I'm sorry, but an uncaught exception occurred.

While running game code:
  File "game/script.rpy", line 154, in script
    $ renpy.notify("Your relationship with "+str(fM)+" decreased by 1","decrease")
  File "game/script.rpy", line 154, in <module>
    $ renpy.notify("Your relationship with "+str(fM)+" decreased by 1","decrease")
TypeError: notify() takes exactly 1 argument (2 given)

-- Full Traceback ------------------------------------------------------------

Full traceback:
  File "game/script.rpy", line 154, in script
    $ renpy.notify("Your relationship with "+str(fM)+" decreased by 1","decrease")
  File "C:\Program Files (x86)\renpy-6.99.13-sdk\renpy\ast.py", line 827, in execute
    renpy.python.py_exec_bytecode(self.code.bytecode, self.hide, store=self.store)
  File "C:\Program Files (x86)\renpy-6.99.13-sdk\renpy\python.py", line 1764, in py_exec_bytecode
    exec bytecode in globals, locals
  File "game/script.rpy", line 154, in <module>
    $ renpy.notify("Your relationship with "+str(fM)+" decreased by 1","decrease")
TypeError: notify() takes exactly 1 argument (2 given)

Windows-8-6.2.9200
Ren'Py 6.99.13.2919
High School Shenaningans 0.017-(Alpha)

The notification code I'm currently using looks like this:

Code: Select all

screen notify(message, status = None):

    zorder 100
    style_prefix "notify"

    frame at notify_appear:
        text "[message!tq]"

    timer 3.25 action Hide('notify')

    if status:
        if status == 'decrease':
            frame at notify_appear:
                text "[message!tq]" style "red_color"

transform notify_appear:
    on show:
        alpha 0
        linear .25 alpha 1.0
    on hide:
        linear .5 alpha 0.0


style notify_frame is empty
style notify_text is gui_text

style notify_frame:
    ypos gui.notify_ypos

    background Frame("gui/notify.png", gui.notify_frame_borders, tile=gui.frame_tile)
    padding gui.notify_frame_borders.padding

style notify_text:
    properties gui.text_properties("notify")
 

That should work, shouldn't it? The notification code is taken from screens.rpy

[cyanic]

As the error says, renpy.notify() only takes one argument. Maybe try giving it a tuple?

Source for renpy.notify(): https://github.com/renpy/renpy/blob/mas ... s.py#L2743

[Scribbles]

you could try to create your own notify screen to take 2 arguments vs modifying the standard one? I'm not sure why that wouldn't work though

[Errilhl]

I get that renpy.notify() only takes one argument - since I've modified the screen notify(), I'm assuming that the actual renpy.notify() is NOT the screen, but something else? Or, a separate function somewhere, probably calling the screen inside that function? If so, can I modify the actual renpy.notify()?

I would prefer to be able to modify this, instead of having to code my own, and then create a new function for showing notifications.

[Errilhl]

As the error says, renpy.notify() only takes one argument. Maybe try giving it a tuple?

Source for renpy.notify(): https://github.com/renpy/renpy/blob/mas ... s.py#L2743

Ah, I get it now. Took me a bit to read through that mess of a page

Okay, so that's an internally coded function - can I redefine that function, but keep the content of it? Ie, just allow for it to use two arguments? I'm a little out of my depth here

[Errilhl]

Okay, I solved this one myself - I was overthinking it...

I modified the screen notify() code to this:

Code: Select all

screen notify(message):

    $ temp_message = None
    $ message_status = None

    zorder 100
    style_prefix "notify"

    if "#" in message:
        $ temp_message = message.split("#")
        $ message = temp_message[0]
        $ message_status = temp_message[1]

    timer 3.25 action Hide('notify')

    if message_status:
        if message_status == "decrease":
            frame at notify_appear:
                text "[message!tq]" style "red_color"
    else:
        frame at notify_appear:
            text "[message!tq]"

transform notify_appear:
    on show:
        alpha 0
        linear .25 alpha 1.0
    on hide:
        linear .5 alpha 0.0


style notify_frame is empty
style notify_text is gui_text

style notify_frame:
    ypos gui.notify_ypos

    background Frame("gui/notify.png", gui.notify_frame_borders, tile=gui.frame_tile)
    padding gui.notify_frame_borders.padding

style notify_text:
    properties gui.text_properties("notify")

Which works fine. I'm quite sure I won't be needing to actually output "#" in the text... If I do, I will have to rethink the separator, but that's for another day

[cyanic]

I was thinking something more like this:

Code: Select all

screen notify(message):
    $ msg = message[0]
    $ other_arg = message[1]

...

$ renpy.notify(("My Message", "someArg"))

[Errilhl]

Ah, thanks, I wasn't aware that I could do that (push an array or list via containing it). That's good information, and will probably help with other things as well. Now I wish there was a "best answer" or "like" button here