6.99.14.2 Prereleased

[jack_norton]

The latest version has a problem with the miss_cache attribute, that breaks compatibility with ALL old saves (which is VERY bad!).
I managed to make it work editing slast.py lines 2020 like this:

Code: Select all

        try:
            context.miss_cache = get_cache(current_screen.miss_cache)
        except:
            context.miss_cache = context.old_cache 

and screen.py line 612 with:

Code: Select all

        try:
            if self.miss_cache:
                self.miss_cache.clear()
        except:
            self.miss_cache={}

but of course this is a hack I did just to make it work I think though this bug should be fixed since breaking ALL saves due to incompatible screens is not good
Thanks again for all your work on Ren'Py, Tom !

[PyTom]

Yep. Good catch. I fixed it in a slightly different way, but that would certainly have worked.

[jack_norton]

Cool glad I was of help
I also believe there's some issue with variable saving. I posted on github about the rollback, but I think the real culprit is the variable saving (I saw the bug using rollback but because with autoreload it would save/reload every time, so I got confused).

Before (all previous ren'py versions):
init:
$var=val
label start:
$var=val2

load save game, and indeed var=val2.
Now it's no longer stored correctly, for example I just tried removing the init, and place:
default var=val
and even loading the previous save above, var is NOT val2, but still val (the value set by default). This is wrong behaviour I think since the values set in the main game code/script should always override the init/default ones, right?
Thanks

[PyTom]

Yes, they certainly should. Do you have a more specific example of this?

[jack_norton]

Code: Select all

define e = Character("Eileen")

init:
    $male=False

#KEEP LINE COMMENTED FIRST TIME YOU RUN
#default male=False

# The game starts here.

label start:

    # Show a background. This uses a placeholder by default, but you can
    # add a file (named either "bg room.png" or "bg room.jpg") to the
    # images directory to show it.

    scene bg room

    # This shows a character sprite. A placeholder is used, but you can
    # replace it by adding a file named "eileen happy.png" to the images
    # directory.

    show eileen happy
    $male=True
    # These display lines of dialogue.
    e "Male is [male]"

    e "Save now, change init to default and load."

    e "Now male is [male]"
    # This ends the game.

    return

basically:
1. first run it keeping default commented and save the game when it says so
2. exit game and uncomment the default
3. load the saved game and male will be False, even if in the code a few lines before was set True

[IrinaLazareva]

Hey. It is not a bug.
It is wrong to use old saves after change of the code.

[jack_norton]

Heh tell that to all the people who played 10+ hours in one of my RPGs

[rayminator]

Hey. It is not a bug.
It is wrong to use old saves after change of the code.

well just imagine that you are playing call of duty or grand theft auto
and there was a major updates for those games that you were playing
the next day you go and play and find out that your save games didn't
work and you were halfway through the game how would you feel
bet that you would be pissed off about that.

keep up the great work
pytom

[PyTom]

Old saves are intended to be supported, within reason. I understand the problem and will fix it.

[Donmai]

I probably shouldn't be entering this conversation, but I know that now a multitude of newbies and non-programmers like myself are wanting to know why

Code: Select all

init:
    $male=False

and not

Code: Select all

default male=False

[jack_norton]

Before the introduction of default, init was the way to define variables. So the fix also preserves the source code of 2-3 years old games, not just the old saves. Also in many cases an init block is much more convenient than default, like if you need to define a bunch of variables, you can do in a single line, instead with default you need to use 1 line each variable.