[SOLVED] renpy.restart_interaction one click too late

[Milkymalk]

I have a map that looks like this:


The textbuttons on the right select a start and destination, and the screen calculates the route and displays it. It works, but with one problem: When I first click one of the buttons, nothing happens. When I click another button (or the same), the screen changes so it looks like it should BEFORE. Basically, the screen is always one button click behind.

This is how the buttons are declared (with a loop, of course):

Code: Select all

textbutton i.name action [SelectedIf(mapnach==i.name), SetVariable('mapnach', i.name), SetVariable('maproute', findroute(mapvon, mapnach)[0]), renpy.restart_interaction]

This button sets the new destination, forces the game to recalculate the route (not drawn yet, only getting the data), and then restart the interaction (i.e. the screen). The screen itself runs a loop to display the dots along the route.

It's as if the screen is redrawn before the changes take place, but I restart the interaction last in the action list for the buttons. So what am I doing wrong?

[Ocelot]

You need to use an actual Action here. You cannot just pass a random function.Use Function screen action.

[Milkymalk]

Huh. I read in another thread to just use it like that (with emphasis on "without parentheses").

I changed it to Function(renpy.restart_interaction) instead, but no difference.

My newest guess is that I need to curry the findroute function, but I regularly give up when it comes to currying functions because I never seem to get it right.

[Ocelot]

Do buttons lag behind too, or is it just the map?

Also, you should not even need restart_interaction: SetVariable restarts it itself.

[Milkymalk]

The buttons don't lag, if you mean their activated state.

[Ocelot]

Your problem is in this: SetVariable('maproute', findroute(mapvon, mapnach)[0]). Remember: the whole reaso,n we need to write stuff like Function('foo', param1, param2) instead of foo(param1, param2), is because all screen code is executed when screen is shown. So we have to create objects, which defer actions to the moment, when you actually press the button, as opposed to executing everything when screen is shown.

Long story short, findroute(mapvon, mapnach)[0] will yield route from mapvon to mapnach according to values of variables as the were when screen was (re)shown.

I think it would be better to let map screen itself handle this:

Code: Select all

screen map():
    $ maproute = findroute(mapvon, mapnach)[0]
    # draw map

[Milkymalk]

You are right. I expected that much and tried around with currying the findroute function, but it seems that currying is just too complicated for me.

Thank you for your help!

[Remix]

You might also like to note that Function() will automatically cause a redraw due to the:

This Action takes an optional _update_screens keyword argument, which defaults to true. When it is true, the interaction restarts and the screens are updated after the function returns.

So putting any call within a Function action *should* then redraw all the screens automatically.
Most, if not all, actions seem to do this anyway, just thought I would mention it.

[Milkymalk]

Thanks, good to know!