Variable Scope Issue

[DoubleProlix]

I've got a function that determines the ratio between two values:

Code: Select all

 
        def ratio(x, y):
            rat = round(x/(x+y),1)
 

Most of the time this works fine. However, when using it with variables belonging to an npc object to get the ratio of "good" interactions with the player vs "bad", it always returns 0.

I think it's a matter of scope, but I'm not sure, or how to let the ratio function access the npc object's variables (call them npc.goodInteraction and npc.badInteraction).

Is there a way to make this work, or will I need to create global NPCGoodInteraction and NPCBadInteraction variables for each character?

[Remix]

If you are passing the variables into the function or method, the variables will become aliases to the passed variable, meaning that should you alter the value you would only alter the alias and not the original.

Without seeing your npc objects or knowing why rat is calculated rather than returned I'd only be guessing at a best approach... Have you considered adding a @property method (or just a get_ratio(self) method) to the npc class and just letting it return a ratio?

[rames44]

Stupid question - are the npc variables integers or floating point numbers? Python 2 still implements integer division as a “floor” operation, so that 5/2=2, not 2.5. This was one of the significant changes in Python 3. Thus, if x and y are both integers, x/(x+y) will always return 0 unless y is zero, at which point it will return 1.

https://stackoverflow.com/questions/183 ... r-division