[Solved] Saving games, classes, and constants. How to use init in the right way?

[Chekhov]

Here is a bit of a mystery to me. I think I'm structuring things incorrectly, but I'm not sure in what way.

I'll make a simplified version of what I'm dealing with.

Code: Select all

init python:
	hair_color_list =   ["blonde", "brown", "black"]
	class Girl(object):
        	def __init__(self):
            		self.hair = random.choice(hair_color_list)
	
	
	

Now you might already see the double bind that I am in. 1. If I put this after a init python: it means that when I load a game, it will be gone.
2. If I put it in regular python:, then there is no Girl class when I load the game and the game crashes.
3. If I put only the Girl class in the init python:, then it misses a hair_color_list
4. Of course I could solve this by defining the list twice, but that seems a very inelegant solution, and bound to lead to errors later on in development.

How should I resolve this?

[xavimat]

What's the problem with number 1?
The code you've provided should work. Classes are defined in an "init python" block.

On the other hand, your code does nothing in an actual game. You need to create instances of that class. If you create the instances in a label, they should be saved and loaded. If you are experiencing a problem in your game, probably lies there. Where do you create your instances?

Btw, renpy has its own random functions, for example "renpy.random.choice()". Better if you use those.

[trooper6]

1) All variables should be initialized outside of any block using either default if that variable might change, or define if it won't. This will fix the problem you are asking about.
2) rather than random.choice, that code should be renpy.random.choice

So try this code (I'm assuming hair color won't change):

Code: Select all

define hair_color_list = ["blonde", "brown", "black"]
init python:
    class Girl(object):
        def __init__(self):
            self.hair = renpy.random.choice(hair_color_list)

default jane = Girl()

label start():
    "Quick check."
    "Jane's hair color is [jane.hair]"
    "Test Over."
    return

[Chekhov]

What's the problem with number 1?
The code you've provided should work.

Because I independantly need the hair_color_list. But since it's been set in a init block, if you load the game, it will be gone/empty.

Btw, renpy has its own random functions, for example "renpy.random.choice()". Better if you use those.

Is it the full random functionality of python? I've been using import random and functionality such as shuffle and sample.

[Chekhov]

1) All variables should be initialized outside of any block using either default if that variable might change, or define if it won't. This will fix the problem you are asking about.

I had been wondering what define was for, I guess this solves it, thanks.

[Alex]

I had been wondering what define was for, I guess this solves it, thanks.

https://www.renpy.org/doc/html/python.h ... -statement

[xavimat]

Because I independantly need the hair_color_list. But since it's been set in a init block, if you load the game, it will be gone/empty.

Are you sure? Why it should be gone when loading? Are you emptying it?

Declaring variables in an init python block causes problems with save/load (that's the reason they should be declared with "default") but that's only a problem if the variable is going to change in-game. If you are using that variable as a constant, it really does not make a difference (but it's better to declare it with "define" though).