Rollback Causing Issues with Random Events (Solved)

[Katy133]

I'm trying to create a random event that happens, and then creates a persistent switch (to prevent the same event from happening twice unless the player does a True Reset). The problem is that if the player Rollsback, they trigger a different random event. How do I prevent this issue from happening? I know a work-around to this would be to turn off Rollback after the random event trigger happens, but turning off Rollback is very not-user-friendly and should only be used as a last resort, if at all.

The script looks like this:

Code: Select all

label present_choice:
            #Randomly chosen. If the player has seen the picked route already, another is chosen.
            #If they have seen all of them, then the "other" event is picked:
            
            $ gift = renpy.random.choice(["event_a","event_b","event_c"])
            
            if gift == "event_a":
                if persistent.a == True:
                    jump present_choice
                "event a"
                $ persistent.a = True
            elif gift == "event_b":
                if persistent.b == True:
                    jump present_choice
                "event b"
                $ persistent.b = True
            elif gift == "event_c":
                if persistent.c == True:
                    jump present_choice
                "event c"
                $ persistent.c = True
            elif gift == "event_other":
                if persistent.a == None:
                    jump present_choice
                if persistent.b == None:
                    jump present_choice
                if persistent.c == None:
                    jump present_choice
                "Other event text."

[philat]

Besides the fact that I don't believe the random event resets (it shouldn't, because renpy.random is designed to work through rollback), wouldn't using persistent in this manner only allow one playthrough anyway? If the only thing you're trying to is ensure that there are no duplicates, you could just use another method like shuffle or pop to bypass using persistent variables.

[Katy133]

Besides the fact that I don't believe the random event resets (it shouldn't, because renpy.random is designed to work through rollback), wouldn't using persistent in this manner only allow one playthrough anyway? If the only thing you're trying to is ensure that there are no duplicates, you could just use another method like shuffle or pop to bypass using persistent variables.

I'd never heard of shuffle or pop before, but I did some digging and changed the code to this:

Code: Select all

if persistent.a == None:
            jump present_choice
        if persistent.b == None:
            jump present_choice
        if persistent.c == None:
            jump present_choice
        This is the /"other/" event."

^^^This is for when the player has seen all the routes.^^^

Then I added this:

Code: Select all

label country_choice:
            #Randomly chosen. If the player has seen the picked route already, another is chosen.
            $ giftlist = ["event_a","event_b","event_b"] #List of choices
            $ renpy.random.shuffle(giftlist) #Pick from the list of choices
            $ gift = giftlist.pop() #Remembers what object from the list was picked

            if gift == "event_a":
                "gift a"
                $ persistent.a = True
            elif gift == "event_b":
                "gift b"
                $ persistent.b = True
            elif gift == "event_c":
                "gift c"
                $ persistent.c = True

Note: I'm not exactly sure what pop() does, but I get an error if I don't include it.

This fixes the rollback issue. The problem is that now the player can get the same route more than once now if they replay the game. I only want the player to be able to see each route once, and then once they've seen all of them, they get the "other" event. How do I do that? Is it something to do with the pop() line?

[philat]

pop returns and removes the item from the list. If that's not what you need, then of course you can use some other method.

Again, renpy.random should not affect rollback in your first example anyway; I don't know what you're doing to make it behave otherwise.

[Katy133]

pop returns and removes the item from the list. If that's not what you need, then of course you can use some other method.

Again, renpy.random should not affect rollback in your first example anyway; I don't know what you're doing to make it behave otherwise.

I don't really understand what "removes the item from the list" means. Because during playtests, I'll sometimes get repeats before seeing all three events (I'll sometimes get event A twice in a row, etc). What does "removing the item from the list" mean?

[Katy133]

Solved! I got help from Empish on Discord (thank you!), and this fixed the issues:

Code: Select all

$ gift_choices = set(["chocolate","vanilla","strawberry"])
    $ gift_list = list(gift_choices) #Makes a list copy of it
    call expression renpy.random.choice(gift_list) #When you want to choose a scene you use renpy.random.choice
    #And then, once it's done (so actually on the next line after the call expression line) you check for emptiness 
    #and if it is empty you just copy from the set again
    if len(gift_list) == 0:
        $ gift_list = list(gift_choices)
        
        
    #You need to indent the labels so that once the player returns, they travel to the next scene.
        label chocolate:
            "text"
            $ gift_list.remove("chocolate") #Then each scene itself will remove itself from the list at the beginning of the label
            return
            
        label vanilla:
            "text"
            $ gift_list.remove("vanilla")
            return
            
        label strawberry:
            "text"
            $ gift_list.remove("strawberry")
            return