What's wrong with my python loop?

[OrsonDeWitt]

So I have a variable X
in screen say(who, what) I have an hbox with the following:

Code: Select all

python:
      while X > 100:
            X = 100

However, when I go through the script and subtract 3, the value goes correctly down to 97. I then add 5, and it shows correctly as 100. However, when I subtract 3 again, it does not go down to 97 as previously but goes only to 99.
This is a very strange behavior and I've been scratching my head for some time now. Could someone more knowledgeable chime in and help me out? Thanks!

[hell_oh_world]

i think doing python statements inside screens are quite unstable, not really sure on why, but I observed that most of the times. so I tend to avoid doing any python statements if I can, such as setting a variable if condition is met, etc.
you can try to prove that by doing a print statement inside the screen... and after the screen shows up try hitting shift + o to see the console to see the printed message.

Code: Select all

screen sample:
  $ print("this should be printed only once right?")

I bet that the code above will make the statement be printed more than once and not only once in the console.
and that's what I mean by unstable.
also note that you don't need to use while loop at all, you can use normal for loop inside screens. but yeah, for while loops you really need a python: statement for that.

Code: Select all

screen sample:
  vbox:
    for i in range(100):
      text "text-{}".format(i + 1)

[Alex]

So I have a variable X
in screen say(who, what) I have an hbox with the following:

Code: Select all

python:
      while X > 100:
            X = 100

...

What's the goal and how the actual code of say screen looks like?
This might be that you need to re-code this part.

[strayerror]

Depending on what you're doing, it might be a better idea to use a callback. Without more context however, only you can decide if it's appropriate or not - I'm guessing your real code is more complex.

The code below will run the statement adjusting the X value each time a say occurs, but outside of the screen. Hope it helps!

Code: Select all

def say_arguments_callback(who, **kwargs):
    X = min(X, 100) # caps X at 100
    return (), kwargs

config.say_arguments_callback = say_arguments_callback

[OrsonDeWitt]

I was trying to invent a horse. What I needed was this: viewtopic.php?t=29339
Guess I had better searched for it. Thanks to everyone who replied!

The code below will run the statement adjusting the X value each time a say occurs, but outside of the screen. Hope it helps!

Thanks! This is like the code from the url, and it works.
I still don't understand though what's wrong with that python code. I mean, thanks to hell_oh_world I understand that it's not a good idea to write loops in screens, but I still don't understand why and what is the difference between writing it in a screen and writing it as "init". Shouldn't it be exactly the same?

[trooper6]

For loops are totally fine in screens and used all the time...I'm just not certain about while loops considering screens refresh regularly.