[Solved]Update sceen variables in realtime

[abysswatcher]

I have the following code:

Code: Select all

init python:
    x=0
    def GetMax(d):
        while x<1:
            try:
                return max(d, key=lambda key: d[key])
            except:
                raise Exception("value did not get returned.")

define MwBelief = {
    'atheism':2,
    'buddhism':3,
    'christian':1,
    'communism':-2,
    'islam':-1,
    'shintoism':-2,
    'taoism':1,
    'yiguandao':0
}
## The game starts here.

screen world:
    text GetMax(MwBelief) xalign 0.5 yalign 0.5 size 20

label start:

    show screen world

    "hello"
    $ MwBelief['atheism'] + 2
    "life good"
    $ MwBelief['christian'] + 5
    "ayyyyy"

    return

While it does function it stays on Buddhism and does not change when the other keys have the largest integers. How can I fix this to make it realtime?

[hell_oh_world]

Things i've noticed:
1. looks like you're trying to make the variable change overtime, default it instead of defining it.
2. In your code you did something like MwBelief['christian'] + 2, which just basically adds the value of Christian and 2, but the added value is not assigned at all so that's why the value does not change because what you did is only an arithmetic operation and not an assignment operation. What you really want is MwBelief['christian'] += 2 or MwBelief['christian'] = MwBelief['christian'] + 2, which adds 2 and the value of Christian and assign that value to the Christian.
3. You can get the maximum value without even creating a function.
Overall, this is how it should look...

Code: Select all

default MwBelief = { # default instead of define
    'atheism':2,
    'buddhism':3,
    'christian':1,
    'communism':-2,
    'islam':-1,
    'shintoism':-2,
    'taoism':1,
    'yiguandao':0
}

screen world:
  text str(max(MwBelief.values())) xalign 0.5 yalign 0.5 size 20 # MwBelief.values() returns all of the values of the dict
  
label start:
  show screen world
  "d1"
  $ MwBelief['christian'] += 2
  "d2"
  $ MwBelief['christian'] += 2
  "d3"

[abysswatcher]

Things i've noticed:
1. looks like you're trying to make the variable change overtime, default it instead of defining it.
2. In your code you did something like MwBelief['christian'] + 2, which just basically adds the value of Christian and 2, but the added value is not assigned at all so that's why the value does not change because what you did is only an arithmetic operation and not an assignment operation. What you really want is MwBelief['christian'] += 2 or MwBelief['christian'] = MwBelief['christian'] + 2, which adds 2 and the value of Christian and assign that value to the Christian.
3. You can get the maximum value without even creating a function.
Overall, this is how it should look...

Code: Select all

default MwBelief = { # default instead of define
    'atheism':2,
    'buddhism':3,
    'christian':1,
    'communism':-2,
    'islam':-1,
    'shintoism':-2,
    'taoism':1,
    'yiguandao':0
}

screen world:
  text str(max(MwBelief.values())) xalign 0.5 yalign 0.5 size 20 # MwBelief.values() returns all of the values of the dict
  
label start:
  show screen world
  "d1"
  $ MwBelief['christian'] += 2
  "d2"
  $ MwBelief['christian'] += 2
  "d3"

Thanks a lot for this. This works really well and exactly like how I want.
The maximum function I made was to return the key of the largest integer not the largest value.

[hell_oh_world]

my bad, missed that part. if that's the case, then it looks like you can just use directly the function max(d, key=lambda key: d[key]).

Code: Select all

screen world:
  text max(MwBelief, key=lambda key: MwBelief[key]) xalign 0.5 yalign 0.5 size 20