check_infinite_loop error in Ren'py 7.4.5

[zmook]

Huh. So this code worked fine in Ren'py 7.4.4, and now in 7.4.5 rollback has stopped working, and it throws this error when I reload:

Code: Select all

I'm sorry, but an uncaught exception occurred.

While running game code:
  File "game/script.rpy", line 94, in script
    if not regressing:
Exception: Possible infinite loop.

-- Full Traceback ------------------------------------------------------------

Full traceback:
  File "game/script.rpy", line 94, in script
    if not regressing:
  File "/Users/colin/dev/sdk/renpy-7.4.5-sdk/renpy/execution.py", line 61, in check_infinite_loop
    raise Exception("Possible infinite loop.")
Exception: Possible infinite loop.

Darwin-20.4.0-x86_64-i386-64bit
Ren'Py 7.4.5.1648
Pirates Logbook 1.0.4
Sun Jun  6 14:27:35 2021

Believe me -- I have downloaded separate copies of the SDK for 7.4.4 and 7.4.5, and it works with one and throws errors with the other.

The code is a simple comic viewer, sort of non-standard use of renpy, but it (used to) work:

Code: Select all

label start:
    scene black
    show screen comic_page(_layer="master")
    show screen metadata_overlay()
    show screen controls()
    
    while True:
        if current_page_n[1] == 1:
            $ renpy.choice_for_skipping()   # triggers autosave
        pause
        $ zoom = False
        if not regressing:
            $ advance_page()  # this method causes a new page to be shown
        $ regressing = False	# there's code under screen controls to handle going back a page

    return

Was the check_infinite_loop code changed on purpose, or has something else gone wrong?

[PyTom]

Just fixed this. https://github.com/renpy/renpy/commit/7 ... 446c9d9fee

[zmook]

Just fixed this. https://github.com/renpy/renpy/commit/7 ... 446c9d9fee

Fantastic!

[Victorius]

Just fixed this. https://github.com/renpy/renpy/commit/7 ... 446c9d9fee

I've tried latest release, 7.4.6.1693, and I got this error when rollbacking to/prior to a loop, I got this error in two loops on 7.4.5, now it's in only one, to clarify in 7.4.4 I can normally rollback to both.

Code: Select all

  File "game/events/explore/construction_shop.rpy", line 239, in script call
    $ exp_scav_girl.start_trade()
  File "game/functions/trade/trading.rpy", line 3, in script
    $renpy.pause(1.0)
  File "renpy/execution.py", line 61, in check_infinite_loop
    raise Exception("Possible infinite loop.")
Exception: Possible infinite loop.

[PyTom]

What does the loop that's causing the problem look like?

[Victorius]

What does the loop that's causing the problem look like?

It's indeed infinite loop, when I made it I was learning renpy, I didn't know how to make it another way, I guess I'll need to rewrite it, but still, it used to work, so I'm reporting this, it might be intended behaviour though. It uses trader.start_trade() ending with this:

Code: Select all

	# Adding to save system
        self.save()

        if not self.unique:
           renpy.show_screen("trade", tr = current_trader, gs_pl = sor_player, gs_tr = sor_trader)
           renpy.call("trading")

        return [sor_player, sor_trader]

and this trading label looks like this:

Code: Select all

label trading:
    while _in_trade:
        $renpy.pause(1.0)

    return

In trade screen once player exits it, it changes _in_trade to false, and exits loop. Pause was to not get infinite loop error, it just makes sure the game doesn't try to calculate it infinite times instantly.

This infinite loop doesn't cause error though:

Code: Select all

label walka:

    $ astral.show_help("Combat")

    while enemy.hp > 0:
        window hide
        if not hand:
            jump end_turn
        $renpy.pause(4.0)
        #$enemy_state = "idle"

    $ player.spirit = int(player.spirit_max)
    $_combat = False
    $_skipping = True
    $renpy.show_screen("battle_notify", message = "Enemy defeated!")