Optimize if-else statement

[bonnie_641]

When I managed to get the drag and drop game to work (thanks to Alex and hell-oh-world) I was very happy. However, when I added more elements, the game became slow (from 3 to 52 cards).
How can I optimize the game?

I think the long "if-else" statement check is the problem

Code: Select all

if _return == "uno": # if the card is 1, displays card contents
    call screen vamos_1() with dissolve
if _return == "dos": # if the card is 2, displays card contents
    call screen vamos_2() with dissolve
#(... rest of code)
if _return == "cincuenta_y_dos": # if the card is 52, displays card contents
    call screen vamos_52() with dissolve

[hell_oh_world]

Suggestions:
1. Do you really need to have a screen for each card? If each card screen shares the same style etc. then you can use parameters in your screen instead...

Code: Select all

screen card(name, pic):
  vbox:
    text name
    add pic

label start:
  if _return == "uno":
    call screen card("uno", "your image name")

2. In relation to #1, you can just do...

Code: Select all

define card_names = ("uno", "dos", "tres")

label start:
  if _return in card_names:
    call screen card(_return, "card {}".format(_return)) # card uno, card dos, etc...

3. If you're going to pursue the multiple if statements, just make the other statements elifs for the matter of logical coding.

[bonnie_641]

Thank you so much!
I followed your recommendation and it works perfectly.

But I have another problem. The minigame performance is very slow (yet).
I was thinking that instead of using all 52 cards in the desk, I would only have 3 cards appear (I would have to apply a 'random' to the 3 cards to randomly show the 52 cards but not in a row).

Code: Select all

# the list of cards will be of 3, but implicitly it must carry the 52 cards
default cards_list = [
    {"name":"uno", "img":"card_face_1", "x_pos":197, "y_pos":202}, 
    {"name":"dos", "img":"card_face_1", "x_pos":197, "y_pos":202}, 
    {"name":"tres", "img":"card_face_1", "x_pos":197, "y_pos":202},  
    ]
default cards = ("img/card1.png", "img/card2.png", (...), "img/card52.png") #<---- does not work
default card_face_1 = renpy.random.shuffle(cards) <---------------------------------------------|

I tried every way I know how to get the cards to appear randomly, but:
1.- It does not show the image associated with the variable assigned to it.
2.- It only appears in order (of the first 3 cards, which is not random).

[Imperf3kt]

I have a blackjack game that uses a (four) deck(s) of 52 cards which may give you some ideas about how to proceed.
I think I've got the code somewhere linked in my signature, but I cannot be sure. - the game itself (for Android) is linked. I haven't made the code available yet.

After work today I'll try to modify it to do what you want and post it here if I manage to get it working. I need to anyway as my game lacks a GUI at the moment.

[bonnie_641]

I have a blackjack game that uses a (four) deck(s) of 52 cards which may give you some ideas about how to proceed.
I think I've got the code somewhere linked in my signature, but I cannot be sure. - the game itself (for Android) is linked. I haven't made the code available yet.

After work today I'll try to modify it to do what you want and post it here if I manage to get it working. I need to anyway as my game lacks a GUI at the moment.

Thank you very much for reply
I hope you can make it (in my game it supports 1 deck with 10 cards).

If you want, I can upload my demo so you can guide you (let me know, ok?)