Simple indexation error

[sculpteur]

Hey guys !

So I was going to finally try to implement an achievment system to my game that I found here : https://github.com/OlegWock/Roselia-ach ... vement.rpy (it is not a robbery since this is free open source ^^ )

BUT

I didn't even begin to work on the adaptation to my existing code than I'am getting this syntax error.
I was thinking it may come from an indexation mistake (with the tabulation space for exemple) but everything I tried seem to make it worst lol

Code: Select all

I'm sorry, but errors were detected in your script. Please correct the
errors listed below, and try again.

File "game/screen_3_complexescreen.rpy", line 201: invalid syntax
                                                                     "cur_prog": , 
                                                                                  ^
    
Ren'Py Version: Ren'Py 7.4.11.2266
Sun Apr 10 04:35:25 2022

So if anyone have an idea from where this is coming from let me know please

Ohw and, also, If someone know a better (easier) free achievement system that I could use don't hesitate to tell me.
I'm not sayin' this because the author seems to be russian or something but because it comming from 17 Sep 2017 when I stared coding in Renpy, at the time I found this an put the link on my desk and this morning I opened it and say "hey, right ! It was the achievement system I was planning to implement"

[Ocelot]

On line 201 of screen_3_complexescreen.rpy you forgot to put a value between "cur_prog" dictionary key and comma.

[rayminator]

this is the part that's giving you the error

Code: Select all

# Define your achievements here
    if not persistent.achievements_dict:
        persistent.achievements_dict = {"*achievent_name*": {"type": 0, # One time achievent
                                                             "title": "Котик!", # Also neame for steam
                                                             "text": "А где же блины?", # description
                                                             "icon": "images/icons/ach1.png" # 96x96 image
                                                             },
                                        "*achievent_name*": {"type": 1, # Progress achievent
                                                             "title": "",
                                                             "text": "",
                                                             "icon": "images/icons/ach.png",
                                                             "cur_prog": , # current progress <--- this one it's either a 0 or "" or "name" but mostly like a 0
                                                             "max_prog": # maximal progress <--- this one as well
                                                             }
                                        }

[sculpteur]

Yep exactly thank you and I fixed it but there is something I don't understand it's why now renpy told me that my variables are not define.

When the code arrived to this line : $ get_achievement(test, trans=achievement_transform)
I got this error :

Code: Select all

I'm sorry, but an uncaught exception occurred.

While running game code:
  File "game/scene_StoryProg1_A_Darkbasment.rpy", line 924, in script
    $ get_achievement(test, trans=achievement_transform)
  File "game/scene_StoryProg1_A_Darkbasment.rpy", line 924, in <module>
    $ get_achievement(test, trans=achievement_transform)
NameError: name 'test' is not defined

-- Full Traceback ------------------------------------------------------------

Full traceback:
  File "game/scene_StoryProg1_A_Darkbasment.rpy", line 924, in script
    $ get_achievement(test, trans=achievement_transform)
  File "renpy/ast.py", line 928, in execute
    renpy.python.py_exec_bytecode(self.code.bytecode, self.hide, store=self.store)
  File "renpy/python.py", line 2245, in py_exec_bytecode
    exec(bytecode, globals, locals)
  File "game/scene_StoryProg1_A_Darkbasment.rpy", line 924, in <module>
    $ get_achievement(test, trans=achievement_transform)
NameError: name 'test' is not defined

Windows-8.1-6.3.9600
Ren'Py 7.4.11.2266
Apocalypse' lovers 0.1
Sun Apr 10 18:16:11 2022

I've try a lot of different combinaison in this (the comment line are what I try in first, then I removed the IF condition to see if it was comming from there but nothing seems to work.

Code: Select all

# Define your achievements here
    persistent.achievements_dict = {"test": {"type": 0,
                                             "title": "zz",
                                             "text": "qsdqsd",
                                             "icon": "images/icons/ach.png"
                                            },
                                    "nome": {"type": 1,
                                             "title": "",
                                             "text": "",
                                             "icon": "images/icons/ach.png",
                                             "cur_prog": 0,
                                             "max_prog": 33
                                            }
                                    }
    # if not persistent.achievements_dict:
    #     persistent.achievements_dict = {"test": {"type": 0, # One time achievent
    #                                                         "title": "Котик!", # Also neame for steam
    #                                                         "text": "А где же блины?", # description
    #                                                         "icon": "images/icons/ach1.png" # 96x96 image
    #                                                         },
    #                                     # "achievent_name2": {"type": 0, # One time achievent
    #                                     #                      "title": "Zizi!", # Also name for steam
    #                                     #                      "text": "Mange mon zizi", # description
    #                                     #                      "icon": "images/icons/ach1.png" # 96x96 image
    #                                     #                      },
    #
    #
    #                                     "*achievent_name*": {"type": 1, # Progress achievent
    #                                                          "title": "",
    #                                                          "text": "",
    #                                                          "icon": "images/icons/ach.png",
    #                                                          "cur_prog": "", # current progress
    #                                                          "max_prog": "" # maximal progress
    #                                                          }
    #                                     }

I also try to change init python: by init -1 python but this it's not working neither.

[rayminator]

you have to define test that's all

what is test for?

define or default test = "" or [] or {} or 0

[sculpteur]

Isn't "test" define by those line :

Code: Select all

    persistent.achievements_dict = {"test": {"type": 0,
                                             "title": "zz",
                                             "text": "qsdqsd",
                                             "icon": "images/icons/ach.png"

or those lines (in my previous try) :

Code: Select all

     if not persistent.achievements_dict:
         persistent.achievements_dict = {"test": {"type": 0, # One time achievent
                                                             "title": "Котик!", # Also neame for steam
                                                             "text": "А где же блины?", # description
                                                             "icon": "images/icons/ach1.png" # 96x96 image
                                                             },

It is supposed to be the name of an achievement that includes different characteristics (value, such as title, images, etc).

[jeffster]

Nope. You define

Code: Select all

persistent.achievements_dict["test"]

# So you can do:

a = persistent.achievements_dict["test"]

But it's not the same as

Code: Select all

test

# So you can not do:

a = test

[rayminator]

Isn't "test" define by those line :

Code: Select all

    persistent.achievements_dict = {"test": {"type": 0,
                                             "title": "zz",
                                             "text": "qsdqsd",
                                             "icon": "images/icons/ach.png"

or those lines (in my previous try) :

Code: Select all

     if not persistent.achievements_dict:
         persistent.achievements_dict = {"test": {"type": 0, # One time achievent
                                                             "title": "Котик!", # Also neame for steam
                                                             "text": "А где же блины?", # description
                                                             "icon": "images/icons/ach1.png" # 96x96 image
                                                             },

It is supposed to be the name of an achievement that includes different characteristics (value, such as title, images, etc).

depend on how you are using test for is it in a class or by itself?

[sculpteur]

what is test for?

As to the author of this system explain here : (https://github.com/OlegWock/Roselia-achievements)

I think it's supposed to be used this way :

Code: Select all

$ get_achievement(name, trans=achievement_transform) # to award a one-time achievement

So when you write this :

define or default test = "" or [] or {} or 0

I suppose it will define a different kind of variable according to the sign after the equal

So what do you think I should choose in order to be able to define those achievement?