Performance issue with imagebutton hover and ATL on gl2

[RyuuYukiyama]

Hi all. So in my team's project we built a combat system scene with visual elements and imagebuttons. We wanted to apply color-effects / tint to the sprites along with ATL transitions, and so far we used im.matrixcolor to apply the highlight effect via BrightnessMatrix.
the imagebuttons are structured like this

Code: Select all

imagebutton:
	idle actor.sprite
	hover lit_up(actor.sprite)
	#other attributes

where lit_up is a wrapper function that applies BrightnessMatrix to the sprite.

It works well in gl1/angle1 renderer if the sprite is a raw image to begin with, but the problem is that we're also using Composite, which im.MatrixColor has a problem with for being displayables.

using ATL matrixcolor or feeding BrightnessMatrix into a Transform() displayable doesn't seem to work in gl1, in gl2 it works but we'd encounter this really strange lag on hover and any atl transitions of the sprites in the screen. Using Creator-Defined Displayables in gl2 also suffers from the same lag.

So my question is that is there a feasible fix or workaround for this?

Since ATL matrixcolor can pretty much achieves what we want with relative ease, but it is this lag that's preventing it from being a solid option.

(video for comparison)

[Imperf3kt]

im.matrixcolor is no longer recommended since the release of renpy 7.4
See this link for details on why.
https://www.renpy.org/doc/html/changelog.html#renpy-7-4

Use matrixcolor instead.
https://www.renpy.org/doc/html/atl.html ... atrixcolor

[RyuuYukiyama]

Use matrixcolor instead.
https://www.renpy.org/doc/html/atl.html ... atrixcolor

Yes, I am aware of ATL's matrixcolor. But that requires gl2 instead, and as I mentioned, using the gl2 renderer causes that strange lag as you can see in the video.

[Imperf3kt]

Are you sure you were using matrixcolor and not im.matrixcolor?
Without any sample of the section where you use this, we cannot tell.

I ask, because according to the changelog, matrixcolor should be significantly faster, not slower.

While previous versions of Ren’Py supported the im.MatrixColor() image manipulator, the new property is much improved. The image manipulator would often take a large fraction of a second, making it too slow for real-time use, and was limited to single images. The new transform property is fast enough that it can be changed every frame if necessary, and can be applied to any displayable

[RyuuYukiyama]

Currently we're using im.matrixcolor because it works with the GL1 renderer and does not cause any lag.

We would love to switch to ATL matrixcolor, but the issue here is that would require switching the renderer to GL2 and the imagebutton hovering has that significant lag on the GL2 renderer.

[PyTom]

What's the definition of lit_up?

[RyuuYukiyama]

What's the definition of lit_up?

Code: Select all

def lit_up(image):
   x = im.MatrixColor(image, im.matrix.brightness(0.23))
   return x

but the issue is that in GL2 renderer, it still lags even if I use ATL matrixcolor like this:

Code: Select all

screen battle_portrait(actor):
   $ isHit = actor.isHit
	
   showif isHit:
      add actor.sprite:
         matrixcolor BrightnessMatrix(0.23)
   else:
      add actor.sprite