Proper way to use condition?

[richycapy]

Hi, this is a simple question for the more experienced RenPy (and Pyton) programmers:

Which one is the correct:

Code: Select all

if not "chloe_imagen_01" in pictures_taken:

or

Code: Select all

if "chloe_imagen_01" not in pictures_taken:

And from this one:

Code: Select all

if not persistent.chloe_imagen_01:

or

Code: Select all

if persistent.chloe_imagen_01 ==  False:

They all seem to work fine, but im not sure they are all correct

Thanks

[Ocelot]

It is more idiomatic to write if "chloe_imagen_01" not in pictures_taken:. First example always makes me double check operator precedence.

Second one is easy: if you ever compare something to boolean literal, you are doing it wrong.

Code: Select all

# correct
if not persistent.chloe_imagen_01:

# incorrect
if persistent.chloe_imagen_01 ==  False:

# correct
if something_happened:

# incorrect
if something_happened == True:

Technically there are differences between conversion to bool, checking for equality with boolean literal and checking for identity with boolean literal, but I only ever needed implicit bool conversion and rarely simultaneous checking variable type and value by testing it with is True.

Generally you want to go with implicit conversion without checking either equality or identity.