[Solved] Concatenate string and variable within menu choice

[GMHLee]

Hi guys, first question. I'm looking to concatenate a string with a calculated variable to a menu choice to show percentage chance as in the example below.

Only thing of course is that the below code won't run, crashing with an error of ": expected". Any help would be appreciated, thanks.

Code: Select all

menu:
        "Test text (" + str(Ava_stats.a*0.4+Ava_stats.b*0.1) + "% chance of +1)":

[m_from_space]

In python it's always useful to use the function format() to connect things to form a string. But in this case you have to do it the following way:

Code: Select all

$ val = Ava_stats.a*0.4+Ava_stats.b*0.1
menu:
    "Test text ([val] % chance of +1)":
        pass

[GMHLee]

Aahh... I see, thanks. I was actually hoping it wasn't something like that and it's my fault for not giving clearer info.

Currently my characters have 6 stats. The above example is for the chance of one stat to go up. In future I envision seeing some events where all six have individual chances of changing, and with or 4 different characters.

That means 24 calculations have to be done regardless of condition and a potential 18 of those wasted on unnecessary overhead. Now this is a visual novel, not the next Mass Effect. It doesn't much matter on that waste but the internal programmer in me cringes at such inefficiency. I assume no other way forward as it stands?

Which lends to my second point, and this is out of the scope of the original question sorry, is that I'm confident I probably couldn't fit the 6 stat percent changes of change and the value of how much they change by onto one line. Probably might have to code a custom player choice menu?

[enaielei]

More pythonic: https://www.renpy.org/doc/html/statemen ... splay_menu
You can also alter the choice screen a bit to use .format then pass the args and kwargs.

Code: Select all

screen choice(items):
    style_prefix "choice"

    vbox:
        for i in items:
            textbutton i.caption.format(*i.args, **i.kwargs) action i.action

label start:
  menu:
    "{}% chance" (0.25*100):
      pass

[GMHLee]

thanks for that, I'll take a look.