[SOLVED] TypeError: iter() returned non-iterator of type 'RevertableList'

[Tess]

I'm trying to make a class that can be iterated over like a list, but I'm not sure how to properly implement __iter__ and __next__.

Code: Select all

class Party():
        """A group of units that fight on the same team, either friend or foe."""

        def __init__(self,*units):
            """Takes Unit instances and makes a list of them in the team variable"""
            self.team = units if isinstance(units,list) else [units]
            self.index = 0
        
        def __call__(self):
            """Lets instances of this class be called directly to get the list of party members"""
            return self.team

        def __iter__(self):
            """Makes this class iterable"""
            return self.team

        def __next__(self):
            """Handles how the iterator moves through the class's party members"""
            if self.index >= len(self.team):
                raise StopIteration
            else:
                self.index += 1
                return self.team[index-1]

        ###Class continues###

However, when I try to run it, I get the error message in the title.

From my understanding, RevertableList is a special Ren'Py list that works with rollback, but still has the properties of a normal list. If that's the case though, I'm not sure why python wouldn't see it as an iterable.

[_ticlock_]

I'm trying to make a class that can be iterated over like a list, but I'm not sure how to properly implement __iter__ and __next__.
However, when I try to run it, I get the error message in the title.

From my understanding, RevertableList is a special Ren'Py list that works with rollback, but still has the properties of a normal list. If that's the case though, I'm not sure why python wouldn't see it as an iterable.

You need to return self:

Code: Select all

        def __iter__(self):
            return self

Same for __call__ method

These lines are likely wrong

Code: Select all

 def __init__(self,*units):
         self.team = units if isinstance(units,list) else [units]

1) You either don't use *unit but unit.

Code: Select all

 def __init__(self,units):
         self.team = units if isinstance(units,list) else [units]

Code: Select all

$ party_1 = Party(unit)
$ party_2 = Party([unit,unit])

2) Or other logic

Code: Select all

 def __init__(self,*units):
         self.team = [unit for unit in units]

Code: Select all

$ party_1 = Party(unit)
$ party_2 = Party(unit,unit)

Warning: Note that renpy can't save iterator objects.

[Tess]

I've been a bit confused on what *args actually creates. Using

Code: Select all

[unit for unit in units]

is working great so far though!

However, when I change __iter__ and __call__ to return self rather than self.team, the error updates to "iter() returned non-iterator type Party"

[_ticlock_]

However, when I change __iter__ and __call__ to return self rather than self.team, the error updates to "iter() returned non-iterator type Party"

1) Not sure why. It seems like it does not see the __next__ method in the class Party. Check the indentation.

Works for this little test:

Code: Select all

init python:
    class Party():
        def __init__(self,*units):
            self.team = [unit for unit in units]
            self.index = 0
        def __iter__(self):
            self.index = 0
            return self
        def __next__(self):
            if self.index >= len(self.team):
                raise StopIteration
            else:
                self.index += 1
                return self.team[self.index-1]

screen party_menu:
    vbox:
        for i in myclass:
            add i
            
label start:
    python:
        a = [TextButton(f"Unit - {i}", action=Return(i)) for i in range(0,10)]
        myclass = Party(*a)
    call screen party_menu
    "Selected : [_return]"

[Ocelot]

A question: which RenPy version do you use? Pyhon 2 and 3 define iterators differently.

[Tess]

Oh yeah, I'm on Ren'Py 7.5. I haven't been able to use the game with 8 so far because pydub doesn't seem to mesh with it for some reason: viewtopic.php?f=8&t=65523

I looked into it though, and realized I have to use next instead of __next__ in Python 2. Changed it to this and it worked perfectly:

Code: Select all

class Party():
        """A group of units that fight on the same team, either friend or foe."""
                
        def __init__(self,*units):
            """Takes Unit instances and makes a list of them in the team variable"""
            self.team = [unit for unit in units]
            self.index = 0
            
	def __iter__(self):
            """Makes this class iterable"""
            self.index = 0
            return self

        def next(self):
            """Handles how the iterator moves through the class's party members"""
            if self.index >= len(self.team):
                raise StopIteration
            else:
                self.index += 1
                return self.team[self.index-1]

Thank you so much for your help guys!