Bar/hotbar range problem

[SleepKirby]

The hotbar problem in this topic was fixed, but then I noticed another problem with the bars.
Take the text speed bar for example. When you put it all the way to the left, _preferences.text_cps would be 200 (as seen by in-game behavior and renpy.watch). When put all the way to the right, it goes to 201.
200 is supposed to be the max value for text speed, and when the bar's all the way right, text speed is supposed to be 0 (indicating infinite speed).

After some testing I noticed the problem happened for both regular Bars and hotbars; and it only happened for the text speed and auto-forward time bars, not the volume bars.

As an example, try this Settings screen (basically from the documentation):

test_settings_screen.rpy

Sample settings screen. Put it in the template game, for example.

(3.38 KiB) Downloaded 18 times

I think I might've found the fix though. In common/00screen.rpy, at line 757, change this:

Code: Select all

        def changed(self, value):

            if self.max_is_zero:
                if value == 0:
                    value = self.range
                else:
                    value = value + 1

to this:

Code: Select all

        def changed(self, value):

            if self.max_is_zero:
                if value == self.range:
                    value = 0
                else:
                    value = value + 1

Is this fix correct?

[PyTom]

It's correct. Thanks for the fix!