Issue with returning item count and displaying only unique values in a list

[McRad]

Hello everybody, I am currently working on my inventory system for the RPG I am developing. I am running into a small issue concerning renpy's handling of python code, as I want to incorporate a FF style display with text and item count as seen below.


I have been working over the past few days to see if I can fix this issue. The farthest I was able to get was to put code inside of the screen that the player uses to access items.

Code: Select all

	for items in armory.inventory:
            $ simparm = set(armory.inventory)
        for items in armory.inventory:
            $ numcheck = armory.inventory.count(items)
        for items in simparm:
            textbutton "[items.name] X[numcheck]" action SetVariable ("itemselect", items)

The code is able to correctly display all unique items with no duplicates (Duplicates meaning that the screen displays the same item twice as textbuttons not two items existing in the list). However the item count for each item is wrong. numcheck will only update itself to the amount of occurrences of the newest item added to the list.

I have tried doing list(set(armory.inventory)), but it does the exact same thing.

I am able to have numcheck work as intended but I would have to change the code to

Code: Select all

         for items in armory.inventory:
	    $ numcheck = armory.inventory.count(items)
	    textbutton "[items.name] X[numcheck]" action SetVariable ("itemselect", items)

Otherwise I am at a loss on how to implement this feature correctly. At this point I am certain that I may need to change up the inventory system I have in place, but I do want to note that I am looking to keep items listed as textbuttons and have their amount listed on screen.

I can provide more code from the inventory code. However I don't think that any other piece of code is conflicting aside from the code listed here.

Any help is appreciated

[philat]

Pretty sure just using a dictionary would make this much simpler.

[McRad]

Pretty sure just using a dictionary would make this much simpler.

I should explain that the items stored in here are instances of class values and I wouldn't believe that a dictionary could be compatible with that

[philat]

No reason that should be the case.

[McRad]

No reason that should be the case.

I was thinking it over and maybe it could work... but I am very unsure of how I could get it to display all the unique data that I want it too...

I want it in individual textbuttons you can click on to use or equip, I'm unsure of how storage works in dictionaries anyways. Can I call each unique one with like [1] and it gets the key and value?

[McRad]

I was thinking it over and maybe it could work... but I am very unsure of how I could get it to display all the unique data that I want it too...

I want it in individual textbuttons you can click on to use or equip, I'm unsure of how storage works in dictionaries anyways. Can I call each unique one with like [1] and it gets the key and value?

I tried doing it and it seemed to be unable to work at all. Anybody else have any other suggestions?

[philat]

I mean, there are too many ways to do what you want to do. You could do it with dictionaries, you could do it with lists of tuples, you could put a separate attribute for each item class to indicate the number of items held. Heck, if you wanted to, you could count the number of duplicates in a list like you were trying to originally, although I don't see why you would. Try looking around the forums for inventory examples. viewtopic.php?f=51&t=34131

[Kia]

I think your use of classes and screens is a bit wrong, instead of trying to use python lines inside a screen, move all of your python code into the classes and have them calculate and handle the variables for you.

the code to show the number of an item should be like:

Code: Select all

text str(inv.numcheck(wood))

anywhere you found yourself typing $ inside a screen, you should tell yourself: there's a better way yo do this