[SOLVED] Dict breaking after rollback or reload

[Saturn_Aeon]

Heyy!! First question ever, so forgive me for any confusion! I'm having some trouble with a dict used to see which character has the most points, and making it a variable that i use as a name in a few rare instances to avoid constantly using if statements. It works fine, but whenever i rollback or try to reload my project, it gives me this error

Code: Select all

I'm sorry, but an uncaught exception occurred.

While running game code:
  File "renpy/common/00start.rpy", line 216, in script call
    call _load_reload_game from _call__load_reload_game_1
  File "renpy/common/00keymap.rpy", line 551, in script
    python hide:
  File "renpy/common/00keymap.rpy", line 551, in <module>
    python hide:
  File "renpy/common/00keymap.rpy", line 562, in _execute_python_hide
    renpy.load(renpy.session["_reload_slot"])
  File "game/scripts/options.rpy", line 123, in execute_default
    default preferences.text_cps = 50
  File "renpy/common/000namespaces.rpy", line 90, in set_default
    if not isinstance(persistent._preference_default, dict):
TypeError: isinstance() arg 2 must be a type or tuple of types

-- Full Traceback ------------------------------------------------------------

Full traceback:
  File "renpy/common/00start.rpy", line 216, in script call
    call _load_reload_game from _call__load_reload_game_1
  File "renpy/common/00keymap.rpy", line 551, in script
    python hide:
  File "C:\Users\REDACTED\Desktop\ㅤ\ARQ\renpy-8.2.1-sdk\renpy\ast.py", line 821, in execute
    renpy.python.py_exec_bytecode(self.code.bytecode, self.hide, store=self.store)
  File "C:\Users\REDACTED\Desktop\ㅤ\ARQ\renpy-8.2.1-sdk\renpy\python.py", line 1178, in py_exec_bytecode
    exec(bytecode, globals, locals)
  File "renpy/common/00keymap.rpy", line 551, in <module>
    python hide:
  File "renpy/common/00keymap.rpy", line 562, in _execute_python_hide
    renpy.load(renpy.session["_reload_slot"])
  File "C:\Users\REDACTED\Desktop\ㅤ\ARQ\renpy-8.2.1-sdk\renpy\loadsave.py", line 829, in load
    log.unfreeze(roots, label="_after_load")
  File "C:\Users\REDACTED\Desktop\ㅤ\ARQ\renpy-8.2.1-sdk\renpy\rollback.py", line 1135, in unfreeze
    self.rollback(0, force=True, label=label, greedy=greedy, on_load=True)
  File "C:\Users\REDACTED\Desktop\ㅤ\ARQ\renpy-8.2.1-sdk\renpy\rollback.py", line 1031, in rollback
    renpy.exports.execute_default_statement(False)
  File "C:\Users\REDACTED\Desktop\ㅤ\ARQ\renpy-8.2.1-sdk\renpy\exports\statementexports.py", line 372, in execute_default_statement
    i.execute_default(start)
  File "game/scripts/options.rpy", line 123, in execute_default
    default preferences.text_cps = 50
  File "renpy/common/000namespaces.rpy", line 90, in set_default
    if not isinstance(persistent._preference_default, dict):
TypeError: isinstance() arg 2 must be a type or tuple of types

the dict in question is this (might look a lil wonky srry):

Code: Select all

label day_2_end(intra_transition=True):

    jump calc_fav

    label calc_fav:

        python:
            dict = {"char 1": 1_romance, 
                    "char 2": 2_romance, 
                    "char 3": 3_romance, 
                    "char 4": 4_romance, 
                    "char 5": 5_romance, 
                    "char 6": 6_romance}
        
            mydate = max(dict, key=dict.get)

        jump day_2end_diag

    label day_2end_diag:

could the error be caused by the

Code: Select all

mydate = max(dict, key=dict.get)

?

[Ocelot]

Check this list:
https://www.renpy.org/doc/html/reserved.html

[PyTom]

Reassigning dict is a really bad idea.

[m_from_space]

could the error be caused by the

Code: Select all

mydate = max(dict, key=dict.get)

?

The other answers are a bit unspecific, I don't know if you realize what you are doing.

But the problem is, that you are using the variable name "dict", which is a reserved Python/Renpy keyword, it's actually a function that returns a dictionary. If you overwrite "dict" by some arbitrary value, this will cause a lot of problems.

Code: Select all

# BAD!
dict = {"char 1": romance_1}

# GOOD!
mydict = {"char 1": romance_1}

# GOOD!
mydict = dict("char 1" = romance_1)

/edit
Changed variable names, see next post.

[jeffster]

Code: Select all

# GOOD!
mydict = {"char 1": 1_romance}

# GOOD!
mydict = dict("char 1" = 1_romance)

By the way, Python identifiers (like variable or function names) shouldn't start with digits.

PS. Ren'Py too:
https://renpy.org/doc/html/language_bas ... statements

Therefore

Code: Select all

# BAD:
1_romance

# OK:
one_romance
p1_romance
_1_romance     # Though "_..." are reserved for Ren'Py internal use
romance_1
romance[1]

[m_from_space]

By the way, Python identifiers (like variable or function names) shouldn't start with digits.

Good find, I wasn't even aware of this here, since it should have thrown an exception in the first place.

[Saturn_Aeon]

But the problem is, that you are using the variable name "dict", which is a reserved Python/Renpy keyword, it's actually a function that returns a dictionary. If you overwrite "dict" by some arbitrary value, this will cause a lot of problems.
[/quote]


This was exactly the problem i was having, i imagined it was something that should be reused (i feel a little silly now of getting this wrong lol). I did not, in fact, know what i was doing