Point Problems (Solved)

[lovelieslemons]

Yet another newb question:
In my game, you must win arguements in order to progress. The arguements are based on the point system, but I keep getting this error:

Code: Select all

I'm sorry, but an uncaught exception occurred.

NameError: name 'Lilly_Trust_points' is not defined

While running game code:
 - script at line 226 of C:\Users\me\Desktop\Love, Lies and Lemons/game/script.rpy
 - python at line 226 of C:\Users\me\Desktop\Love, Lies and Lemons/game/script.rpy.

-- Full Traceback ------------------------------------------------------------

  File "C:\Users\me\Desktop\renpy-6.11.1\renpy\bootstrap.py", line 254, in bootstrap
  File "C:\Users\me\Desktop\renpy-6.11.1\renpy\main.py", line 310, in main
  File "C:\Users\me\Desktop\renpy-6.11.1\renpy\main.py", line 93, in run
  File "C:\Users\me\Desktop\renpy-6.11.1\renpy\execution.py", line 259, in run
  File "C:\Users\me\Desktop\renpy-6.11.1\renpy\ast.py", line 574, in execute
  File "C:\Users\me\Desktop\renpy-6.11.1\renpy\python.py", line 957, in py_exec_bytecode
  File "C:\Users\me\Desktop\Love, Lies and Lemons/game/script.rpy", line 226, in <module>
NameError: name 'Lilly_Trust_points' is not defined

While running game code:
 - script at line 226 of C:\Users\me\Desktop\Love, Lies and Lemons/game/script.rpy
 - python at line 226 of C:\Users\me\Desktop\Love, Lies and Lemons/game/script.rpy.

Ren'Py Version: Ren'Py 6.11.1b

The relevant blocks of code are:

Code: Select all

label start:
   $ run = False
   $ Lilly_Approval_points = 0
   $ Lilly_Trust_Points = 0
   $ mad_science_Points = 

And:

Code: Select all

      show text "You have entered an arguement. You're aim is to gain Lilly's approval by  saying the right things. "
   menu:
    "Aren't we friends?":
        $ Lilly_Trust_points += 1
        j "Come on. Aren't we friends"
        hide l norm
        show l sup
        l "I suppose."
    "Explain":
        $ Lilly_Trust_points += 2
        j "Can you imagine how I must feel, not knowing where my sister is?"
        hide l norm
        show l sup
        l "I guess your right."
    "Threaten Her":
       $ Lilly_Trust_points -= 3
       j "If you don't, I'll-."
       hide l norm
       show l wid
       l "Glare at me all day?."
       
if Lilly_Trust_points > 2:
         l "Well, I guess I can trust you"
         jump expo
if Lilly_Trust_Points < 1 :
         l "There is no way I'm telling you anything!"
         jump suspend
          

Sorry, I got the wrong sub-forum. My newb-ness got ahead of me. Anyways, would a move be possible?

[fortaat]

On the init block it's Lilly_Trust_Points while in the code it's Lilly_Trust_points.

It's a good practice to capitalize all your variables (the things that make the point system) to avoid such errors.

[lovelieslemons]

Thanks for helping out, but I'm still getting the error.

[fortaat]

Does the error pop when you're loading a game, or when you first run it?
If it's the first, start a new game and see what happens.

[killdream]

On the init block it's Lilly_Trust_Points while in the code it's Lilly_Trust_points.

It's a good practice to capitalize all your variables (the things that make the point system) to avoid such errors.

Actually, in Python it's best practices to write your variables in lowercase, with words separated by underscores.

Thanks for helping out, but I'm still getting the error.

Ren'Py saves the variables with a save file, but since you're defining variables at the `label start`, they won't be redefined when you load from this save game (since `label start` won't be executed). You have to delete your save file and start over.

[Jake]

It's a good practice to capitalize all your variables (the things that make the point system) to avoid such errors.

Actually, in Python it's best practices to write your variables in lowercase, with words separated by underscores.

Honestly, the important thing is just that you come up with some kind of convention and stick with it. So long as you personally always write your variable names in lowercase with underscores, or capital letters, or camel case or whatever, you can easily type the same variable name twice without thinking and have them identical letter-for-letter, case-for-case, which is the whole point.

Sure, it helps a little when you're writing Python to use lowercase with underscores just because that's what most Python code is written in so you'll find it easier to use example code and other Python programmers can read your code more quickly. And it might help a little in some other language (I don't know, COBOL?) if you make all your variable names uppercase. But since most people aren't going to be showing others their Ren'Py script that much, having a convention is more important than it being the same convention most other people use for that language, IMO.

[sake-bento]

Edit: I'll leave this post up, but I suggest reading Jake's posts below this before you consider trying it. While I think it's a solution to your problem, I'm not a master programmer by any stretch and it may create new problems if you use this.

--

You're creating the variables under the start label when you should be initializing them under init. Try something like so:

Code: Select all

init:
   $ run = False
   $ Lilly_Approval_points = 0
   $ Lilly_Trust_Points = 0
   $ mad_science_Points = 0

label start:
    "What a great day to perform some mad science with my trustworthy partner, Lilly!"
    menu:
        # All your menu stuff here

Also keep in mind that capitalization matters, as others have already said. If you capitalize something when you create it, you have to keep that same capitalization when you do things to it later.

And thread moved to the Ren'py support forum as requested.

[Jake]

You're creating the variables under the start label when you should be initializing them under init.

Actually, I would advise doing exactly what they did - initializing them right after the start label, and not in init.

Init is for things which don't change during the game - image and Character definitions and stuff like that. Things which are going to change in-game should be defined in-game as well.

It's probably actually OK for simple variables[*], but as a general rule declaring stuff which changes in an init block is asking for trouble with loading and saving - even for end-users, outside of development - and it's a bad habit to get into. Declaring your vars after the 'start' label means you have to play from the beginning during development, but you don't have to worry about the player's experience.





[*] By "simple variables" I basically mean "numbers, True/False values and maybe strings of text". Lists and dictionaries are likely to not be saved if you declared them in init, object instances are definitely problematic, but even strings can sometimes not get saved despite being saved.

[sake-bento]

A quick look over some code I've nicked from a couple other Ren'py developers shows variables being declared under the init tag rather than after the start, and initialized within the game when necessary (in the case of complex variables like arrays).

lovelieslemons, are you getting this error, even if you start playing the game from the very beginning?

[Jake]

A quick look over some code I've nicked from a couple other Ren'py developers shows variables being declared under the init tag

Then those other Ren'Py developers had bad habits in this case.

Seriously, I would strongly recommend against declaring anything that changes in-game in an init block, whatever people have or haven't got away with in the past. It's guaranteed to break for some data types and iffy for some others. PyTom has given exactly the same advice in the past, for that matter.

[lovelieslemons]

Thanks to every body who responded, I took all your advice and fixed the problem. I'm not getting the error when i start from the beggining, only when I load. Anyways, Thanks for your help.