Advice: Follow the PEP8 guidelines for your python code. This will make things easier to read, more maintainable, and easier for other people to work on. Generally, try to be more consistent with your style, even if you deviate from PEP8.
eg: Your fighter class
Code: Select all
init python:
class fighter:
def __init__(self, FTR = "", ALIVE=True, ATK=0, DEF=0, SPD=0, MG=0, HP=0, MP=0, ELEM="", skill_set=[], pic_card="", pic_sprite="", sprite_pos=[]) :
self.FTR = FTR
self.ALIVE = ALIVE # true or false
self.ATK = ATK
self.DEF = DEF
self.SPD = SPD
self.MG = MG
self.HP = HP
self.MP = MP
self.ELEM = ELEM
self.skill_set = skill_set
self.pic_card = pic_card
self.pic_sprite = pic_sprite
self.sprite_pos = sprite_pos
def registerSkill(self, skill_name):
self.skill_set.append(skill_name)
def normalizeStats(self):
print "Normalizing stats."
stat_list = [self.ATK, self.DEF, self.SPD, self.MG, self.HP, self.MP]
for i in stat_list:
if i <= 0:
i = 0
Would look better as:
Code: Select all
init python:
class Fighter(object):
""" Short description of the Fighter class.
Args:
FTR (str): Short description here.
ALIVE (bool):
ATK (int):
# etc, etc
"""
def __init__(self, FTR="", is_alive=True, ATK=0, DEF=0, SPD=0, MG=0, HP=0, MP=0, elem="", skill_set=[], pic_card="", pic_sprite="", sprite_pos=[]):
self.FTR = FTR
self.is_alive = is_alive
self.ATK = ATK
self.DEF = DEF
self.SPD = SPD
self.MG = MG
self.HP = HP
self.MP = MP
self.elem = elem
self.skill_set = skill_set
self.pic_card = pic_card
self.pic_sprite = pic_sprite
self.sprite_pos = sprite_pos
self.stat_list = [self.ATK, self.DEF, self.SPD, self.MG, self.HP, self.MP]
def register_skill(self, skill_name):
self.skill_set.append(skill_name)
def normalize_stats(self):
print "Normalizing stats."
for index, value in enumerate(self.stat_list):
if value <= 0:
self.stat_list[index] = 0
return self.stat_list
You could also probably refactor that stat_list into something cleaner, unless you absolutely need 2 ways to access it. I'll leave that to you.
Of course, whatever docstring style you choose, if any, is up to you. I just used google's style here because I like it.