Referencing a class member via a variable

[togs]

Suppose I have a class named fruittypes, with members including apple, banana and cherry. There are attributes for name, shape, size and color.

I also have a function like this:

label fruitdata( fchoice):
"Your chosen fruit, the [fchoice.name], is typically [fchoice.size], [fchoice.shape] and appears in shades of [fchoice.color]."
return

Now, if I call the function like this:

call fruitdata( cherry )

It tells me a cherry is small, round and red.

Then I try this:

python:
fchoice = renpy.input( "What's your favorite fruit?", length = 8 )
... some stuff to strips spaces, standardize case, etc.

call fruitdata( fchoice )

I get an error saying 'unicode' object has no attribute 'name', because it's treating fchoice as if it were the class member, rather than what fchoice references.

Fairly new to this, so any help would be appreciated!

[Ocelot]

Suppose I have a class named fruittypes, with members including apple, banana and cherry. There are attributes for name, shape, size and color.

I assume it is used like this:

Code: Select all

define cherry = Fruittypes("cherry", "small", "round", "red")
define apple_g = Fruittypes("apple (Granny Smith)", "medium", "round", "green")
# . . .
# other fruits

Then I try this:

python:
fchoice = renpy.input( "What's your favorite fruit?", length = 8 )
... some stuff to strips spaces, standardize case, etc.

call fruitdata( fchoice )

I get an error saying 'unicode' object has no attribute 'name', because it's treating fchoice as if it were the class member, rather than what fchoice references.

Fairly new to this, so any help would be appreciated!

Lets start with line call fruitdata( fchoice ). When you used call fruitdata( cherry ), you passed a reference to object of type Fruittypes and specific content. Now you are passing fchoice, which is something returned by renpy.input and processed. renpy.input returns a string — a type (called unicode internally) containing characters you can manipulate, replace, etc.
So, to speak, fruitdata label expected to be passed an actual fruit, but got a list of paper wuth fruit name written on it. When it tries to do things it can do with a fruit with a piece of paper, it couldn't. Hence the error.

What can you do?

* First of all, you can set up some code which takes string, compares it with predefined strings and calls fruitdata with correnct fruit. This is high maintenace, annoying to extend, DRY-violating route, we won't do that.

* Second, you can try to get a member of store variable based on string your player enters. This is viable solution, but I prefer next one.

* Third, you can store your fruits in some data type where you can look up any fruit by its name. Such data type is called Dictionary in Python:

Code: Select all

# Simplest way
define fruits = {
    "cherry": Fruittypes("cherry", "small", "round", "red"),
    "apple": Fruittypes("apple (Granny Smith)", "medium", "round", "green"),
}
# . . .
# input stuff
if fchoice in fruits: # Need to check if this is a fruit we know, otherwise we get another error
    fchoice = fruits[fcoice] # Replace string in fchoice with actual fruit
    call fruitdata( fchoice ) # Print fruit data
else:
    "I do not know anything about fruit called [fdata]"

# If you prefer your fruits to still be defined as separate variables you can do that:
define cherry = # . . .
define apple_g  = # . . .

define fruits = {
    'cherry': cherry.
    'apple': apple_g,
}

# Or even
define fruits = {f.name: f for f in [cherry, apple]}

[Remix]

... or reference the string inside the store scope...

python:
fchoice = renpy.input( "What's your favorite fruit?", length = 8 )
... some stuff to strips spaces, standardize case, etc.

call fruitdata( getattr(store, fchoice) ) ### <<--- getattr

[togs]

Thank you all - I appreciate all the suggestions - going to go away and experiment!